From patchwork Wed Nov 30 22:30:15 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 13060536 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A9A0C352A1 for ; Wed, 30 Nov 2022 22:30:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229534AbiK3WaX (ORCPT ); Wed, 30 Nov 2022 17:30:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44384 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229597AbiK3WaV (ORCPT ); Wed, 30 Nov 2022 17:30:21 -0500 Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 390EF92A06 for ; Wed, 30 Nov 2022 14:30:21 -0800 (PST) Received: by mail-wr1-x430.google.com with SMTP id w15so16217197wrl.9 for ; Wed, 30 Nov 2022 14:30:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=BDZzkQyiysskVYuTmzk+3p8oEPfSeUMrQN2y4xwT6XA=; b=cFrSjsl8EK1KAIsc+wU2QsmBJVDEeLl2vCCqIzZhGKe+EZ69aHwTwSMcS7CQ5FT8YQ N3gYRqQMi8asM2ntcuO8HrUToowvq56lvPhtOEc1niogreQMTpkAg/JwB7WgkR7/brW/ UwkNAYylStTKndl6p9+RY3Xsujsu2HKcAt5zQ6N8taPCAtQ56sZ9LmX1DroutB+mD4kX cZHtEs5Pglx90ARr2hQuWRepLXuQ64TRqRx1Zt2IQ9qzrBqFR6Td3FtSXKiarIdZsElG 9JneyjXSQvRuZBx4VzwqGkG7A2ByLqVQklkSEr73jq7VJxUkP8iHzJc0HLjAQOGS5VLq 4bwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BDZzkQyiysskVYuTmzk+3p8oEPfSeUMrQN2y4xwT6XA=; b=ecV6lHC2gMcnSar0HUtHolUfSiKTO9yoeC2bRxQB2VwhpVuDG469a42fznoXol2vxw 5x5iNGRSL0+TIpPdNP3Q9EPkAdtI2D9x0F/tcm7ByTJ7Yv0R+OYSk9KbHwXpU41Iod5e b/OHvkIXZwfh7PG59Q7gEGIO090j/AO+y0gwGCAmA50t0+gauVP55kjSxaCpvChspUgi SdLDObeOw2hNAuqw6hpU3dePEGezi3uJT7tOLfL5rwnX+kjhwXtkefjMLnuhXevIbGvO a+Hcmn1Gl3vij8W9inrjFXUZf5DEhVMJyozh9prUROmDshmdV6H2yxyDH54GKUdI0Xju hH7A== X-Gm-Message-State: ANoB5pkjZJyUN0omYaqYB/awoU1tOcCElFjEgP9ZJMbie8ky3+61Bsvd +GIRUBUd25Xrmz6lf9EmkdooqqiGWpQ= X-Google-Smtp-Source: AA0mqf4IxPhbse1MY214EEX+p8gciIeUWMLok7GkftpmhKtcc9Ro9XYh0vy37NksT8fG+G+xAiPZfw== X-Received: by 2002:a05:6000:1811:b0:242:310a:300b with SMTP id m17-20020a056000181100b00242310a300bmr2198520wrh.698.1669847419666; Wed, 30 Nov 2022 14:30:19 -0800 (PST) Received: from ?IPV6:2a01:c22:77d6:e700:1465:fbc6:a2a6:9b65? (dynamic-2a01-0c22-77d6-e700-1465-fbc6-a2a6-9b65.c22.pool.telefonica.de. [2a01:c22:77d6:e700:1465:fbc6:a2a6:9b65]) by smtp.googlemail.com with ESMTPSA id hg6-20020a05600c538600b003a6125562e1sm3177413wmb.46.2022.11.30.14.30.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 30 Nov 2022 14:30:19 -0800 (PST) Message-ID: Date: Wed, 30 Nov 2022 23:30:15 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: [PATCH net-next 2/2] r8169: enable GRO software interrupt coalescing per default Content-Language: en-US From: Heiner Kallweit To: Jakub Kicinski , David Miller , Realtek linux nic maintainers , Eric Dumazet , Paolo Abeni Cc: "netdev@vger.kernel.org" References: In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org There are reports about r8169 not reaching full line speed on certain systems (e.g. SBC's) with a 2.5Gbps link. There was a time when hardware interrupt coalescing was enabled per default, but this was changed due to ASPM-related issues on few systems. So let's use software interrupt coalescing instead and enable it using new function netdev_sw_irq_coalesce_default_on(). Even with these conservative settings interrupt load on my 1Gbps test system reduced significantly. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169_main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c index 5bc1181f8..f4e160888 100644 --- a/drivers/net/ethernet/realtek/r8169_main.c +++ b/drivers/net/ethernet/realtek/r8169_main.c @@ -5282,6 +5282,8 @@ static int rtl_init_one(struct pci_dev *pdev, const struct pci_device_id *ent) dev->hw_features |= NETIF_F_RXALL; dev->hw_features |= NETIF_F_RXFCS; + netdev_sw_irq_coalesce_default_on(dev); + /* configure chip for default features */ rtl8169_set_features(dev, dev->features);