| Message ID | d9dd214b-3027-4f60-b0e8-6f34a0c76582@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 2e20bf8cc05766dcd0357cdfcada49e1bc45512b |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] r8169: remove unused flag RTL_FLAG_TASK_RESET_NO_QUEUE_WAKE | expand |
On Mon, Dec 02, 2024 at 09:14:35PM +0100, Heiner Kallweit wrote: > After 854d71c555dfc3 ("r8169: remove original workaround for RTL8125 > broken rx issue") this flag isn't used any longer. So remove it. > > Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> > --- > drivers/net/ethernet/realtek/r8169_main.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c > index 739707a7b..4b96b4ad8 100644 > --- a/drivers/net/ethernet/realtek/r8169_main.c > +++ b/drivers/net/ethernet/realtek/r8169_main.c > @@ -623,7 +623,6 @@ struct rtl8169_tc_offsets { > > enum rtl_flag { > RTL_FLAG_TASK_RESET_PENDING, > - RTL_FLAG_TASK_RESET_NO_QUEUE_WAKE, > RTL_FLAG_TASK_TX_TIMEOUT, > RTL_FLAG_MAX > }; > @@ -4723,8 +4722,6 @@ static void rtl_task(struct work_struct *work) > reset: > rtl_reset_work(tp); > netif_wake_queue(tp->dev); > - } else if (test_and_clear_bit(RTL_FLAG_TASK_RESET_NO_QUEUE_WAKE, tp->wk.flags)) { > - rtl_reset_work(tp); > } > } > > -- > 2.47.1 > Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com> Thanks > >
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Mon, 2 Dec 2024 21:14:35 +0100 you wrote: > After 854d71c555dfc3 ("r8169: remove original workaround for RTL8125 > broken rx issue") this flag isn't used any longer. So remove it. > > Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> > --- > drivers/net/ethernet/realtek/r8169_main.c | 3 --- > 1 file changed, 3 deletions(-) Here is the summary with links: - [net-next] r8169: remove unused flag RTL_FLAG_TASK_RESET_NO_QUEUE_WAKE https://git.kernel.org/netdev/net-next/c/2e20bf8cc057 You are awesome, thank you!
diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c index 739707a7b..4b96b4ad8 100644 --- a/drivers/net/ethernet/realtek/r8169_main.c +++ b/drivers/net/ethernet/realtek/r8169_main.c @@ -623,7 +623,6 @@ struct rtl8169_tc_offsets { enum rtl_flag { RTL_FLAG_TASK_RESET_PENDING, - RTL_FLAG_TASK_RESET_NO_QUEUE_WAKE, RTL_FLAG_TASK_TX_TIMEOUT, RTL_FLAG_MAX }; @@ -4723,8 +4722,6 @@ static void rtl_task(struct work_struct *work) reset: rtl_reset_work(tp); netif_wake_queue(tp->dev); - } else if (test_and_clear_bit(RTL_FLAG_TASK_RESET_NO_QUEUE_WAKE, tp->wk.flags)) { - rtl_reset_work(tp); } }
After 854d71c555dfc3 ("r8169: remove original workaround for RTL8125 broken rx issue") this flag isn't used any longer. So remove it. Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> --- drivers/net/ethernet/realtek/r8169_main.c | 3 --- 1 file changed, 3 deletions(-)