| Message ID | e0349ee5-76e6-4ff4-812f-4aa0d3f76ae7@moroto.mountain (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 1bc9d12e1c924b76fb71da97db8818eaae5c30a1 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] ice: fix error code in ice_eswitch_attach() | expand |
On 27.11.2023 13:59, Dan Carpenter wrote: > Set the "err" variable on this error path. > > Fixes: fff292b47ac1 ("ice: add VF representors one by one") > Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> > --- Thanks Dan! Reviewed-by: Wojciech Drewek <wojciech.drewek@intel.com> > drivers/net/ethernet/intel/ice/ice_eswitch.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/intel/ice/ice_eswitch.c b/drivers/net/ethernet/intel/ice/ice_eswitch.c > index 3f80e2081e5d..ca118bc37e44 100644 > --- a/drivers/net/ethernet/intel/ice/ice_eswitch.c > +++ b/drivers/net/ethernet/intel/ice/ice_eswitch.c > @@ -669,8 +669,10 @@ ice_eswitch_attach(struct ice_pf *pf, struct ice_vf *vf) > ice_eswitch_stop_reprs(pf); > > repr = ice_repr_add_vf(vf); > - if (IS_ERR(repr)) > + if (IS_ERR(repr)) { > + err = PTR_ERR(repr); > goto err_create_repr; > + } > > err = ice_eswitch_setup_repr(pf, repr); > if (err)
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Mon, 27 Nov 2023 15:59:17 +0300 you wrote: > Set the "err" variable on this error path. > > Fixes: fff292b47ac1 ("ice: add VF representors one by one") > Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> > --- > drivers/net/ethernet/intel/ice/ice_eswitch.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Here is the summary with links: - [net-next] ice: fix error code in ice_eswitch_attach() https://git.kernel.org/netdev/net-next/c/1bc9d12e1c92 You are awesome, thank you!
diff --git a/drivers/net/ethernet/intel/ice/ice_eswitch.c b/drivers/net/ethernet/intel/ice/ice_eswitch.c index 3f80e2081e5d..ca118bc37e44 100644 --- a/drivers/net/ethernet/intel/ice/ice_eswitch.c +++ b/drivers/net/ethernet/intel/ice/ice_eswitch.c @@ -669,8 +669,10 @@ ice_eswitch_attach(struct ice_pf *pf, struct ice_vf *vf) ice_eswitch_stop_reprs(pf); repr = ice_repr_add_vf(vf); - if (IS_ERR(repr)) + if (IS_ERR(repr)) { + err = PTR_ERR(repr); goto err_create_repr; + } err = ice_eswitch_setup_repr(pf, repr); if (err)
Set the "err" variable on this error path. Fixes: fff292b47ac1 ("ice: add VF representors one by one") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> --- drivers/net/ethernet/intel/ice/ice_eswitch.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)