diff mbox series

[net-next,10/10] selftests: forwarding: router_nh: Add a diagram

Message ID ec60c64b682c307d8db9c9cb1f35d6e43bebd1e5.1712940759.git.petrm@nvidia.com (mailing list archive)
State Accepted
Commit 74ddac073cfe5f47c1509b665ec9b30df1fcd71c
Delegated to: Netdev Maintainers
Headers show
Series selftests: Assortment of fixes | expand

Checks

Context Check Description
netdev/series_format success Posting correctly formatted
netdev/tree_selection success Clearly marked for net-next
netdev/ynl success Generated files up to date; no warnings/errors; no diff in generated;
netdev/fixes_present success Fixes tag not required for -next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 8 this patch: 8
netdev/build_tools success Errors and warnings before: 0 this patch: 0
netdev/cc_maintainers success CCed 7 of 7 maintainers
netdev/build_clang success Errors and warnings before: 8 this patch: 8
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success net selftest script(s) already in Makefile
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 8 this patch: 8
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 20 lines checked
netdev/build_clang_rust success No Rust files in patch. Skipping build
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0
netdev/contest success net-next-2024-04-15--15-00 (tests: 961)

Commit Message

Petr Machata April 12, 2024, 5:03 p.m. UTC
This test lacks a topology diagram, making the setup not obvious.
Add one.

Signed-off-by: Petr Machata <petrm@nvidia.com>
---
 .../testing/selftests/net/forwarding/router_nh.sh  | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

Comments

Hangbin Liu April 15, 2024, 8:31 a.m. UTC | #1
On Fri, Apr 12, 2024 at 07:03:13PM +0200, Petr Machata wrote:
> This test lacks a topology diagram, making the setup not obvious.
> Add one.
> 
> Signed-off-by: Petr Machata <petrm@nvidia.com>
> ---
>  .../testing/selftests/net/forwarding/router_nh.sh  | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/tools/testing/selftests/net/forwarding/router_nh.sh b/tools/testing/selftests/net/forwarding/router_nh.sh
> index f3a53738bdcc..92904b01eae9 100755
> --- a/tools/testing/selftests/net/forwarding/router_nh.sh
> +++ b/tools/testing/selftests/net/forwarding/router_nh.sh
> @@ -1,6 +1,20 @@
>  #!/bin/bash
>  # SPDX-License-Identifier: GPL-2.0
>  
> +# +-------------------------+  +-------------------------+
> +# | H1                      |  |                      H2 |
> +# |               $h1 +     |  |               $h2 +     |
> +# |      192.0.2.2/24 |     |  |   198.51.100.2/24 |     |
> +# |  2001:db8:1::2/64 |     |  |  2001:db8:2::2/64 |     |
> +# +-------------------|-----+  +-------------------|-----+
> +#                     |                            |
> +# +-------------------|----------------------------|-----+
> +# | R1                |                            |     |
> +# |              $rp1 +                       $rp2 +     |
> +# |      192.0.2.1/24              198.51.100.1/24       |
> +# |  2001:db8:1::1/64             2001:db8:2::1/64       |
> +# +------------------------------------------------------+
> +
>  ALL_TESTS="
>  	ping_ipv4
>  	ping_ipv6
> -- 
> 2.43.0
> 
Reviewed-by: Hangbin Liu <liuhangbin@gmail.com>
diff mbox series

Patch

diff --git a/tools/testing/selftests/net/forwarding/router_nh.sh b/tools/testing/selftests/net/forwarding/router_nh.sh
index f3a53738bdcc..92904b01eae9 100755
--- a/tools/testing/selftests/net/forwarding/router_nh.sh
+++ b/tools/testing/selftests/net/forwarding/router_nh.sh
@@ -1,6 +1,20 @@ 
 #!/bin/bash
 # SPDX-License-Identifier: GPL-2.0
 
+# +-------------------------+  +-------------------------+
+# | H1                      |  |                      H2 |
+# |               $h1 +     |  |               $h2 +     |
+# |      192.0.2.2/24 |     |  |   198.51.100.2/24 |     |
+# |  2001:db8:1::2/64 |     |  |  2001:db8:2::2/64 |     |
+# +-------------------|-----+  +-------------------|-----+
+#                     |                            |
+# +-------------------|----------------------------|-----+
+# | R1                |                            |     |
+# |              $rp1 +                       $rp2 +     |
+# |      192.0.2.1/24              198.51.100.1/24       |
+# |  2001:db8:1::1/64             2001:db8:2::1/64       |
+# +------------------------------------------------------+
+
 ALL_TESTS="
 	ping_ipv4
 	ping_ipv6