From patchwork Fri Sep 17 06:27:10 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 12501201 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8AC5C433F5 for ; Fri, 17 Sep 2021 06:27:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8EE3D60FBF for ; Fri, 17 Sep 2021 06:27:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233714AbhIQG2j (ORCPT ); Fri, 17 Sep 2021 02:28:39 -0400 Received: from de-smtp-delivery-102.mimecast.com ([194.104.109.102]:31572 "EHLO de-smtp-delivery-102.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233157AbhIQG2i (ORCPT ); Fri, 17 Sep 2021 02:28:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1631860035; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=HWKHW7ZoiNVaIy0mfo3LS1NtMKPljl8Txy7BqM8aytQ=; b=IMMEwipMnSpV5qPVcVNpI56p6qKegI16gbBPl5XOBItKJmHNJxKZ+hr4QR9GV9u5BwphqX enUCNypDP8eqWDghfdS4cmWDTgmXxlTrswj9sy0lJFa7+Fb1Pwn4BZGOiQvi5JJIbc5Gla 71wUOzLu30v4wTFPhyD/kBaJ6Cn9H60= Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01lp2054.outbound.protection.outlook.com [104.47.0.54]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-15-s9X0kTPrPVa5rO-rDPYSaw-1; Fri, 17 Sep 2021 08:27:14 +0200 X-MC-Unique: s9X0kTPrPVa5rO-rDPYSaw-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Q25i2ebGgB79+F5oGE336FliMymy9jndvpF6sCPFMpktHzv9fCJBD6V6/RDhbTOb/8v+/+UTwoWnDgX2PGmf6EWUU/Vewo44f+sVf0543zaZlqQ7Zy0Iv0S5r10aSgjfyShMbf6JidR3YQOMwF2IR3TVP8XebuZNgXLFMKxBGR5Fv9oHff0rrmu2THRs8k0sTQlbtzhclbn8CBQsEHkGKzLJjTYQQipsJwzYUJ1TMYT0hWkk9LDatGGg8M7tvQ5L0FzlBBjXfSUzWg87jy4fduWxsWH5bPXCfC3QFRHwCToW8MUCPm2X3d3BN3dxi01MwPnbC/0hEElEeQHtcUhxOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=HWKHW7ZoiNVaIy0mfo3LS1NtMKPljl8Txy7BqM8aytQ=; b=iFP8GZQRiNLvgYFHFfd/cZRlx8c/xh71RocLtmSEFJu2Abx7keyP9LNBpMsYGYff/5D1h35pA01hG8x7RnsBhpCEOhxxFQ68z0RTE4qJfJgCvCJ0HLFQH2UR0JnMmAObOC8q8+1dR0qSzW6ZD6IsxzreDn1OWuSIhxZ+LLvcVCb5B2pgKkWZxMMACkRNvvtoX2bgHV9n/rPPg7PvRtP16pu07bOv6xyq+brhLPgpZG/2HLsKs1MFyJ6/abf289bCZHTUWwBeOijnQ30I/rANzj+x8/fN5U449y2yRGjJyMTeLPP/p4fhnjeMthEK+d98gpfTmn8etW2orxZyrraV4Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com; Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR04MB5904.eurprd04.prod.outlook.com (2603:10a6:803:e6::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.14; Fri, 17 Sep 2021 06:27:12 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::4d37:ec64:4e90:b16b%7]) with mapi id 15.20.4523.016; Fri, 17 Sep 2021 06:27:12 +0000 To: "netdev@vger.kernel.org" Cc: Paul Durrant , Wei Liu , "xen-devel@lists.xenproject.org" From: Jan Beulich Subject: [PATCH net][RESEND] xen-netback: correct success/error reporting for the SKB-with-fraglist case Message-ID: Date: Fri, 17 Sep 2021 08:27:10 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 Content-Language: en-US X-ClientProxiedBy: AM0PR02CA0108.eurprd02.prod.outlook.com (2603:10a6:208:154::49) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [10.156.60.236] (37.24.206.209) by AM0PR02CA0108.eurprd02.prod.outlook.com (2603:10a6:208:154::49) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.14 via Frontend Transport; Fri, 17 Sep 2021 06:27:12 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b47cc365-0393-44f9-1ca5-08d979a42f49 X-MS-TrafficTypeDiagnostic: VI1PR04MB5904: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4502; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6rZLycOOX7gljECy/boTmyNvbOBUQfqn0Jjmn8YQ50XeNytYYLyVDdJLwkWzdonrZ650Jp+BjDknK/Ui8GZtgIY6xMP5FPMiw/l3iVlq8yh9ZRI4K/6akHdFxrK+4P0WKnienl0MHtuUbXQjpHVf1lUBxOL9DYKUhFN8q+B1kqDKwu3ERrx5KtXzK/dlJCuzFVS/QYglp9TxVvnglX6nAXHHui+rax1LpXhT9hMepTSZgijQa5OpN///GAHZQKiBpjM+af3wbTu4BZYKazBEH2OB3AHE3vwFfsoznuwWJ0HBZarRCRyA/Wm2/Ipozx4IYxUD8zfa6RdKDnatAUoWEfP42C/KTsZ896jM4Jnw+/4xqQNgo9Hc78VU08I8QyFaEJZUGJ8QVUuikYyb8JO13fmIQgF8KvPxKgR658WAW+emP4xiYpfwOcfW91GWlYipLy7IPUXvluVguAM0DArrhx/WeXA9GJebUtWReVWsblQW0B949Vgw/Rs58Tbc/ELo2hYaB4xT2Q0d072ccNlOigrTrUgtqoXZyX+rMuSry9Jn2c7/Ktz7pME80pkTI198jX5NwI7HHayfh5TkpouLbE+A1gFlltkEWdl+o1MF1vR3LhJoeed2dlEYnM68ZiVNpxwysOMcvGT6XfLDNp/2tI6jtk7JeROkshUXJ+/axz91zcf1FqHtUNjY3Cv8C2jnTHdb1sVUhjFoAS2elx/jvVcyQPjpFDBbVpCvLVZsJkU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(2906002)(4326008)(8936002)(66556008)(38100700002)(956004)(4744005)(2616005)(6916009)(66946007)(54906003)(508600001)(186003)(6486002)(16576012)(8676002)(31696002)(31686004)(316002)(36756003)(5660300002)(26005)(86362001)(66476007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?RGaZeEM4MQFYZlbULrk0A1g2QDlM?= =?utf-8?q?0hCow6M1kyB8GJxyG98IBnhsY/FekxFUX/I5uo6U2EQ/wkDGO7eQkI6hg9YyG6N3S?= =?utf-8?q?saXLYS+rOGi31Okr4kuulYqYoPEPR3DTF2WVAzYrTLnB0wvMY1zKFN9d0gZn1FXqb?= =?utf-8?q?Z3S6m5KTpkEwjqnyBwu+eo8cQhXzeL32OO94WK8cVrESpyYu98lktvBdaWbULkops?= =?utf-8?q?vL6MC/I8Y5VIdkOD47jDIchYsoygLRH/bspxsVrCIDTn2wWw37BUxh1jkPibAWyb4?= =?utf-8?q?ctph9eYqb2U6SAN+ADMi6Q7lTaqWeA5CTim8uhj16hJkZh6t9dIidgmDsC8pe6UGS?= =?utf-8?q?r7v1fKAR4WujX40bG9r/0VcTDz+vC3KT0iyRh+ILdifdKkTNPaqQT57lTCKj6fhcr?= =?utf-8?q?XhyxmUKRIDEOPX2NxutX8OJulgTGp7Sb+8SGy2O+aV3ji9kghtJrA/lQUiIjdK4Bn?= =?utf-8?q?bGMslO2xNss+qWJdDa3TyJF/yVQvt41GwX85rKGNZjd7G3J6oK7jxxtkiiaHjYtM7?= =?utf-8?q?YXVvHXHhB3EJTgGX91QmM6mhKr77MAUEtGZJ43eWV3YgBmSNDb0Vl/Zn8VQikn8IJ?= =?utf-8?q?MzcNU4KQQDevoZzxT4JT8HSxp3ULxBnNLhJ6KUUJM2ei+zZlUuji5wbQKqO1glkus?= =?utf-8?q?kb2nSYTATBIwelIo/vI8P1T0anvGBlZwBYK6wdgvQvL5HG5DvzY/xd2sQN2dPfwhK?= =?utf-8?q?iEcYMOI2rrCpWqWk9fASbjZ4ZeAsiHyXqXiKU0uDFnzm6ltpa8G9yuD2dwrL7lAnH?= =?utf-8?q?vbHndqVJtgSM1hm3ZtNvBMp1LotErBpM95nq0JReDNVh0ql1+ej1esTbZTikR3Vaf?= =?utf-8?q?wGx2RFCi0JObXQAhG4K4glMHGTLfGpFgjiaSe4Cb9xlRrwNiGh99CK36H0tZwrBiE?= =?utf-8?q?nBioktEaduqwPg1+nI1BdYA/vghZ3kfols+Bko2e3q5cGuAN8+MvyW0z3fpOykNgX?= =?utf-8?q?MaInqptsKqdBhJLXJbG6QURiKetRu6+PmK8ZHHtRscp0FlWUh079WtRr10Xxx5Wr1?= =?utf-8?q?wlpGXRqZuyWSZhc/BeEcLQzvFsz1Sbz4LsjpVygXTlK8D0KQqJ/3mgUe3hQoykpOU?= =?utf-8?q?CPqO0AdIMeS+nbIO/kuGYLlIk0pdhCERy4krX6MDclZtsNlgotuQb9B+fopH5NjpP?= =?utf-8?q?SqMfwOaH9CHoRieIGYGBH0JQ6Y+PUYPuELMxs+toyt0fM3vJyhw9DyX32cwXwGRvf?= =?utf-8?q?JCeJJ5cOyKdanDIHoDUB+CAnfOMXsAZd3W/YamGEM/TiFPAtX2OQLpS5QyEpdzeuU?= =?utf-8?q?WnrWhI+HbqySlpkO?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: b47cc365-0393-44f9-1ca5-08d979a42f49 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Sep 2021 06:27:12.6642 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2TG1/VZESJloobIdrSjVMOIwvM8w5GQv39oMIE/jTFYNbdmyGELDJ1l0J6iPzWm1cnRyOXZUNi/WJ9L8zsfl0w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5904 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org When re-entering the main loop of xenvif_tx_check_gop() a 2nd time, the special considerations for the head of the SKB no longer apply. Don't mistakenly report ERROR to the frontend for the first entry in the list, even if - from all I can tell - this shouldn't matter much as the overall transmit will need to be considered failed anyway. Signed-off-by: Jan Beulich Reviewed-by: Paul Durrant --- a/drivers/net/xen-netback/netback.c +++ b/drivers/net/xen-netback/netback.c @@ -499,7 +499,7 @@ check_frags: * the header's copy failed, and they are * sharing a slot, send an error */ - if (i == 0 && sharedslot) + if (i == 0 && !first_shinfo && sharedslot) xenvif_idx_release(queue, pending_idx, XEN_NETIF_RSP_ERROR); else