| Message ID | f23d1a60d2c9d2fb72e32dcb0eaa5f7e867a3d68.1692327891.git.daniel@makrotopia.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 90308679c297ffcbb317c715ef434e9fb3c881dc |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] net: pcs: lynxi: implement pcs_disable op | expand |
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Fri, 18 Aug 2023 04:07:46 +0100 you wrote: > When switching from 10GBase-R/5GBase-R/USXGMII to one of the interface > modes provided by mtk-pcs-lynxi we need to make sure to always perform > a full configuration of the PHYA. > > Implement pcs_disable op which resets the stored interface mode to > PHY_INTERFACE_MODE_NA to trigger a full reconfiguration once the LynxI > PCS driver had previously been deselected in favor of another PCS > driver such as the to-be-added driver for the USXGMII PCS found in > MT7988. > > [...] Here is the summary with links: - [net-next] net: pcs: lynxi: implement pcs_disable op https://git.kernel.org/netdev/net-next/c/90308679c297 You are awesome, thank you!
diff --git a/drivers/net/pcs/pcs-mtk-lynxi.c b/drivers/net/pcs/pcs-mtk-lynxi.c index b0f3ede945d96..8501dd365279b 100644 --- a/drivers/net/pcs/pcs-mtk-lynxi.c +++ b/drivers/net/pcs/pcs-mtk-lynxi.c @@ -233,11 +233,19 @@ static void mtk_pcs_lynxi_link_up(struct phylink_pcs *pcs, } } +static void mtk_pcs_lynxi_disable(struct phylink_pcs *pcs) +{ + struct mtk_pcs_lynxi *mpcs = pcs_to_mtk_pcs_lynxi(pcs); + + mpcs->interface = PHY_INTERFACE_MODE_NA; +} + static const struct phylink_pcs_ops mtk_pcs_lynxi_ops = { .pcs_get_state = mtk_pcs_lynxi_get_state, .pcs_config = mtk_pcs_lynxi_config, .pcs_an_restart = mtk_pcs_lynxi_restart_an, .pcs_link_up = mtk_pcs_lynxi_link_up, + .pcs_disable = mtk_pcs_lynxi_disable, }; struct phylink_pcs *mtk_pcs_lynxi_create(struct device *dev,
When switching from 10GBase-R/5GBase-R/USXGMII to one of the interface modes provided by mtk-pcs-lynxi we need to make sure to always perform a full configuration of the PHYA. Implement pcs_disable op which resets the stored interface mode to PHY_INTERFACE_MODE_NA to trigger a full reconfiguration once the LynxI PCS driver had previously been deselected in favor of another PCS driver such as the to-be-added driver for the USXGMII PCS found in MT7988. Signed-off-by: Daniel Golle <daniel@makrotopia.org> --- drivers/net/pcs/pcs-mtk-lynxi.c | 8 ++++++++ 1 file changed, 8 insertions(+)