mbox series

[v3,00/10] fsdax, xfs: Add reflink&dedupe support for fsdax

Message ID 20210319015237.993880-1-ruansy.fnst@fujitsu.com (mailing list archive)
Headers show
Series fsdax, xfs: Add reflink&dedupe support for fsdax | expand

Message

ruansy.fnst@fujitsu.com March 19, 2021, 1:52 a.m. UTC
From: Shiyang Ruan <ruansy.fnst@cn.fujitsu.com>

This patchset is attempt to add CoW support for fsdax, and take XFS,
which has both reflink and fsdax feature, as an example.

Changes from V2:
 - Fix the mistake in iomap_apply2() and dax_dedupe_file_range_compare()
 - Add CoW judgement in dax_iomap_zero()
 - Fix other code style problems and mistakes

Changes from V1:
 - Factor some helper functions to simplify dax fault code
 - Introduce iomap_apply2() for dax_dedupe_file_range_compare()
 - Fix mistakes and other problems
 - Rebased on v5.11

One of the key mechanism need to be implemented in fsdax is CoW.  Copy
the data from srcmap before we actually write data to the destance
iomap.  And we just copy range in which data won't be changed.

Another mechanism is range comparison.  In page cache case, readpage()
is used to load data on disk to page cache in order to be able to
compare data.  In fsdax case, readpage() does not work.  So, we need
another compare data with direct access support.

With the two mechanism implemented in fsdax, we are able to make reflink
and fsdax work together in XFS.


Some of the patches are picked up from Goldwyn's patchset.  I made some
changes to adapt to this patchset.

(Rebased on v5.11)
==

Shiyang Ruan (10):
  fsdax: Factor helpers to simplify dax fault code
  fsdax: Factor helper: dax_fault_actor()
  fsdax: Output address in dax_iomap_pfn() and rename it
  fsdax: Introduce dax_iomap_cow_copy()
  fsdax: Replace mmap entry in case of CoW
  fsdax: Add dax_iomap_cow_copy() for dax_iomap_zero
  iomap: Introduce iomap_apply2() for operations on two files
  fsdax: Dedup file range to use a compare function
  fs/xfs: Handle CoW for fsdax write() path
  fs/xfs: Add dedupe support for fsdax

 fs/dax.c               | 596 ++++++++++++++++++++++++++---------------
 fs/iomap/apply.c       |  56 ++++
 fs/iomap/buffered-io.c |   2 +-
 fs/remap_range.c       |  45 +++-
 fs/xfs/xfs_bmap_util.c |   3 +-
 fs/xfs/xfs_file.c      |  29 +-
 fs/xfs/xfs_inode.c     |   8 +-
 fs/xfs/xfs_inode.h     |   1 +
 fs/xfs/xfs_iomap.c     |  58 +++-
 fs/xfs/xfs_iomap.h     |   4 +
 fs/xfs/xfs_iops.c      |   7 +-
 fs/xfs/xfs_reflink.c   |  17 +-
 include/linux/dax.h    |   7 +-
 include/linux/fs.h     |  15 +-
 include/linux/iomap.h  |   7 +-
 15 files changed, 602 insertions(+), 253 deletions(-)

--
2.30.1

Comments

riteshh March 23, 2021, 3:27 p.m. UTC | #1
On 3/19/21 7:22 AM, Shiyang Ruan wrote:
> From: Shiyang Ruan <ruansy.fnst@cn.fujitsu.com>
> 
> This patchset is attempt to add CoW support for fsdax, and take XFS,
> which has both reflink and fsdax feature, as an example.


Thanks for the patchset. I have tried reviewing the series from logical
correctness and to some extent functional correctness.
Since I am not well versed with the core functionality of COW operation,
so I may have requested for some clarifications where I could not get
the code 100% on what it is doing.


> 
> (Rebased on v5.11)
> ==
> 
Thanks. Yes, I see some conflicts when tried to apply on latest kernel.

-ritesh
Christoph Hellwig April 2, 2021, 7:49 a.m. UTC | #2
Shiyang, Dan:

given that the whole reflink+dax thing is going to take a while and thus
not going to happen for this merge window, what about queueing up the
cleanup patches 1,2 and 3 so that we can reduce the patch load a little?
ruansy.fnst@fujitsu.com April 2, 2021, 8:18 a.m. UTC | #3
> -----Original Message-----
> From: Christoph Hellwig <hch@lst.de>
> Sent: Friday, April 2, 2021 3:50 PM
> Subject: Re: [PATCH v3 00/10] fsdax,xfs: Add reflink&dedupe support for fsdax
> 
> Shiyang, Dan:
> 
> given that the whole reflink+dax thing is going to take a while and thus not going
> to happen for this merge window, what about queueing up the cleanup patches
> 1,2 and 3 so that we can reduce the patch load a little?

OK.  I'll send a new version of these 3 patches based on latest comment.


--
Thanks,
Ruan Shiyang.