mbox series

[v2,0/4] ocfs2 bugs fixes exposed by fstests

Message ID 20240402014651.13723-1-glass.su@suse.com (mailing list archive)
Headers show
Series ocfs2 bugs fixes exposed by fstests | expand

Message

Su Yue April 2, 2024, 1:46 a.m. UTC
The patchset is to fix some wrong behavior of ocfs2 exposed
by fstests.

Patch 1,2 are about AIO+DIO vs hole punching. generic/300

Patch 3 fixes inode link count mismatch after power failure.
tests/generic/040,041,104,107,336

patch 4 fixes wrong atime with mount option realtime. tests/generic/192

Changelog:
v2:
  - Fix typos and amend commit message about the functions called
  by ocfs2_dio_wr_get_block in patch 1.
  - Add rvb to patch 2,3,4.
  
Su Yue (4):
  ocfs2: return real error code in ocfs2_dio_wr_get_block
  ocfs2: fix races between hole punching and AIO+DIO
  ocfs2: update inode fsync transaction id in ocfs2_unlink and
    ocfs2_link
  ocfs2: use coarse time for new created files

 fs/ocfs2/aops.c  | 2 --
 fs/ocfs2/file.c  | 2 ++
 fs/ocfs2/namei.c | 4 +++-
 3 files changed, 5 insertions(+), 3 deletions(-)

Comments

Andrew Morton April 4, 2024, 1:51 a.m. UTC | #1
On Tue,  2 Apr 2024 09:46:47 +0800 Su Yue <glass.su@suse.com> wrote:

> The patchset is to fix some wrong behavior of ocfs2 exposed
> by fstests.

Thanks.  We should consider which of these fixes should be backported
into -stable kernels.  For that we should provide, for each patch:

- A description of the userspace-visible impact of the bug and

- A suitable Fixes: target to tell -stable maintainers how far back
these fixes are needed.

Please could we give some consideration to these matters?
Su Yue April 4, 2024, 5:54 a.m. UTC | #2
> On Apr 4, 2024, at 09:51, Andrew Morton <akpm@linux-foundation.org> wrote:
> 
> On Tue,  2 Apr 2024 09:46:47 +0800 Su Yue <glass.su@suse.com> wrote:
> 
>> The patchset is to fix some wrong behavior of ocfs2 exposed
>> by fstests.
> 
> Thanks.  We should consider which of these fixes should be backported
> into -stable kernels.  For that we should provide, for each patch:
> 
> - A description of the userspace-visible impact of the bug and
> 
Yeah. I should elaborate more in cover letter.

> - A suitable Fixes: target to tell -stable maintainers how far back
> these fixes are needed.
> 
Necessary Indeed.

> Please could we give some consideration to these matters?
> 
Sure. I will do these after vacation in next version.