From patchwork Fri Apr 10 22:44:26 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tariq Saeed X-Patchwork-Id: 6200201 Return-Path: X-Original-To: patchwork-ocfs2-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 50D589F2EC for ; Fri, 10 Apr 2015 22:46:43 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 89E7820254 for ; Fri, 10 Apr 2015 22:46:42 +0000 (UTC) Received: from aserp1040.oracle.com (aserp1040.oracle.com [141.146.126.69]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7CDDA20173 for ; Fri, 10 Apr 2015 22:46:41 +0000 (UTC) Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id t3AMjDBs028448 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 10 Apr 2015 22:45:13 GMT Received: from oss.oracle.com (oss-old-reserved.oracle.com [137.254.22.2]) by aserv0022.oracle.com (8.13.8/8.13.8) with ESMTP id t3AMj90R027242 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 10 Apr 2015 22:45:09 GMT Received: from localhost ([127.0.0.1] helo=lb-oss.oracle.com) by oss.oracle.com with esmtp (Exim 4.63) (envelope-from ) id 1Yghfg-0001Zz-Sx; Fri, 10 Apr 2015 15:45:08 -0700 Received: from ca-tasaeed-srv1.us.oracle.com ([130.35.69.238]) by oss.oracle.com with esmtp (Exim 4.63) (envelope-from ) id 1Yghf2-0001Yi-La for ocfs2-devel@oss.oracle.com; Fri, 10 Apr 2015 15:44:28 -0700 Received: by ca-tasaeed-srv1.us.oracle.com (Postfix, from userid 1733) id C2316807C3; Fri, 10 Apr 2015 15:44:27 -0700 (PDT) From: Tariq Saeed To: ocfs2-devel@oss.oracle.com Date: Fri, 10 Apr 2015 15:44:26 -0700 Message-Id: <1428705866-26954-1-git-send-email-tariq.x.saeed@oracle.com> X-Mailer: git-send-email 1.7.1 Cc: mfasheh@suse.de Subject: [Ocfs2-devel] [PATCH 1/1] automated tool detected uninitialized variable use in ocfs2_local_alloc_find_clear_bits X-BeenThere: ocfs2-devel@oss.oracle.com X-Mailman-Version: 2.1.9 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: ocfs2-devel-bounces@oss.oracle.com Errors-To: ocfs2-devel-bounces@oss.oracle.com X-Source-IP: aserv0022.oracle.com [141.146.126.234] X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Orabug: 19060842 In ocfs2_local_alloc_find_clear_bits(), local int numbits is used without being initialized in an error path. Signed-off-by: Tariq Saeed --- fs/ocfs2/localalloc.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/fs/ocfs2/localalloc.c b/fs/ocfs2/localalloc.c index 0440134..978a6e0 100644 --- a/fs/ocfs2/localalloc.c +++ b/fs/ocfs2/localalloc.c @@ -847,6 +847,7 @@ static int ocfs2_local_alloc_find_clear_bits(struct ocfs2_super *osb, if (!alloc->id1.bitmap1.i_total) { bitoff = -1; + numfound = -1; goto bail; }