[14/22] ocfs2: add the missing return value check of ocfs2_xattr_get_clusters

Commit Message

Andrew Morton Aug. 27, 2013, 9:05 p.m. UTC

From: Joseph Qi <[e-mail]>
Subject: ocfs2: add the missing return value check of ocfs2_xattr_get_clusters

In ocfs2_xattr_value_attach_refcount(), if error occurs when calling
ocfs2_xattr_get_clusters(), it will go with unexpected behavior since
local variables p_cluster, num_clusters and ext_flags are declared without
initialization.

Signed-off-by: Joseph Qi <[e-mail]>
Cc: Joel Becker <[e-mail]>
Cc: Mark Fasheh <[e-mail]>
Acked-by: Jie Liu <[e-mail]>
Signed-off-by: Andrew Morton <[e-mail]>
---

 fs/ocfs2/xattr.c |    4 ++++
 1 file changed, 4 insertions(+)

Patch

diff -puN fs/ocfs2/xattr.c~ocfs2-add-the-missing-return-value-check-of-ocfs2_xattr_get_clusters fs/ocfs2/xattr.c
--- a/fs/ocfs2/xattr.c~ocfs2-add-the-missing-return-value-check-of-ocfs2_xattr_get_clusters
+++ a/fs/ocfs2/xattr.c
@@ -5881,6 +5881,10 @@  static int ocfs2_xattr_value_attach_refc
 	while (cpos < clusters) {
 		ret = ocfs2_xattr_get_clusters(inode, cpos, &p_cluster,
 					       &num_clusters, el, &ext_flags);
+		if (ret) {
+			mlog_errno(ret);
+			break;
+		}
 
 		cpos += num_clusters;
 		if ((ext_flags & OCFS2_EXT_REFCOUNTED))