diff mbox

[22/22] ocfs2: remove unused variable ip in dlmfs_get_root_inode()

Message ID 20130827210516.E4DC95A4276@corp2gmr1-2.hot.corp.google.com (mailing list archive)
State New, archived
Headers show

Commit Message

Andrew Morton Aug. 27, 2013, 9:05 p.m. UTC 
From: Joseph Qi <joseph.qi@huawei.com>
Subject: ocfs2: remove unused variable ip in dlmfs_get_root_inode()

Variable ip in dlmfs_get_root_inode() is defined but not used.  So clean
it up.

Signed-off-by: Joseph Qi <joseph.qi@huawei.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 fs/ocfs2/dlmfs/dlmfs.c |    3 ---
 1 file changed, 3 deletions(-)

Comments

jeff.liu Aug. 29, 2013, 9:54 a.m. UTC | #1 
On 08/28/2013 05:05 AM, akpm@linux-foundation.org wrote:

> From: Joseph Qi <joseph.qi@huawei.com>
> Subject: ocfs2: remove unused variable ip in dlmfs_get_root_inode()
> 
> Variable ip in dlmfs_get_root_inode() is defined but not used.  So clean
> it up.
> 
> Signed-off-by: Joseph Qi <joseph.qi@huawei.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

Looks good.  Reviewed-by: Jie Liu <jeff.liu@oracle.com>

> ---
> 
>  fs/ocfs2/dlmfs/dlmfs.c |    3 ---
>  1 file changed, 3 deletions(-)
> 
> diff -puN fs/ocfs2/dlmfs/dlmfs.c~ocfs2-cleanup-unused-variable-ip-in-dlmfs_get_root_inode fs/ocfs2/dlmfs/dlmfs.c
> --- a/fs/ocfs2/dlmfs/dlmfs.c~ocfs2-cleanup-unused-variable-ip-in-dlmfs_get_root_inode
> +++ a/fs/ocfs2/dlmfs/dlmfs.c
> @@ -401,11 +401,8 @@ static struct inode *dlmfs_get_root_inod
>  {
>  	struct inode *inode = new_inode(sb);
>  	umode_t mode = S_IFDIR | 0755;
> -	struct dlmfs_inode_private *ip;
>  
>  	if (inode) {
> -		ip = DLMFS_I(inode);
> -
>  		inode->i_ino = get_next_ino();
>  		inode_init_owner(inode, NULL, mode);
>  		inode->i_mapping->backing_dev_info = &dlmfs_backing_dev_info;
> _
> 
> _______________________________________________
> Ocfs2-devel mailing list
> Ocfs2-devel@oss.oracle.com
> https://oss.oracle.com/mailman/listinfo/ocfs2-devel
diff mbox

Patch

diff -puN fs/ocfs2/dlmfs/dlmfs.c~ocfs2-cleanup-unused-variable-ip-in-dlmfs_get_root_inode fs/ocfs2/dlmfs/dlmfs.c
--- a/fs/ocfs2/dlmfs/dlmfs.c~ocfs2-cleanup-unused-variable-ip-in-dlmfs_get_root_inode
+++ a/fs/ocfs2/dlmfs/dlmfs.c
@@ -401,11 +401,8 @@  static struct inode *dlmfs_get_root_inod
 {
 	struct inode *inode = new_inode(sb);
 	umode_t mode = S_IFDIR | 0755;
-	struct dlmfs_inode_private *ip;
 
 	if (inode) {
-		ip = DLMFS_I(inode);
-
 		inode->i_ino = get_next_ino();
 		inode_init_owner(inode, NULL, mode);
 		inode->i_mapping->backing_dev_info = &dlmfs_backing_dev_info;