From patchwork Mon Jul 28 15:26:32 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: HIMANGI SARAOGI X-Patchwork-Id: 4713311 Return-Path: X-Original-To: patchwork-ocfs2-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 267E49F375 for ; Tue, 12 Aug 2014 16:10:52 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 56B3120125 for ; Tue, 12 Aug 2014 16:10:51 +0000 (UTC) Received: from aserp1040.oracle.com (aserp1040.oracle.com [141.146.126.69]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7414E200DF for ; Tue, 12 Aug 2014 16:10:50 +0000 (UTC) Received: from acsinet22.oracle.com (acsinet22.oracle.com [141.146.126.238]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id s7CGAWUW012106 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 12 Aug 2014 16:10:33 GMT Received: from oss.oracle.com (oss-external.oracle.com [137.254.96.51]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id s7CGARmp025033 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 12 Aug 2014 16:10:27 GMT Received: from localhost ([127.0.0.1] helo=oss.oracle.com) by oss.oracle.com with esmtp (Exim 4.63) (envelope-from ) id 1XHEeZ-0001Az-F1; Tue, 12 Aug 2014 09:10:27 -0700 Received: from acsinet22.oracle.com ([141.146.126.238]) by oss.oracle.com with esmtp (Exim 4.63) (envelope-from ) id 1XBmoz-0004WJ-Kz for ocfs2-devel@oss.oracle.com; Mon, 28 Jul 2014 08:26:42 -0700 Received: from aserp1020.oracle.com (aserp1020.oracle.com [141.146.126.67]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id s6SFQeHa011830 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 28 Jul 2014 15:26:41 GMT Received: from mail-pd0-f178.google.com (mail-pd0-f178.google.com [209.85.192.178]) by aserp1020.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id s6SFQdaR020424 (version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=OK) for ; Mon, 28 Jul 2014 15:26:40 GMT Authentication-Results: aserp1020.oracle.com; dkim=pass reason="2048-bit key" header.d=gmail.com header.i=@gmail.com header.b=ss7pkHfb Received: by mail-pd0-f178.google.com with SMTP id w10so9985346pde.23 for ; Mon, 28 Jul 2014 08:26:39 -0700 (PDT) X-Received: by 10.68.222.136 with SMTP id qm8mr39616979pbc.92.1406561199568; Mon, 28 Jul 2014 08:26:39 -0700 (PDT) Received: from localhost ([125.17.132.98]) by mx.google.com with ESMTPSA id fn1sm17974060pbc.77.2014.07.28.08.26.36 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Mon, 28 Jul 2014 08:26:38 -0700 (PDT) Date: Mon, 28 Jul 2014 20:56:32 +0530 From: Himangi Saraogi To: Mark Fasheh , Joel Becker , ocfs2-devel@oss.oracle.com, linux-kernel@vger.kernel.org Message-ID: <20140728152632.GA2926@himangi-Dell> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) X-Flow-Control-Info: class=Pass-to-MM reputation=ipRisk-All ip=209.85.192.178 ct-class=R5 ct-vol1=-93 ct-vol2=8 ct-vol3=8 ct-risk=49 ct-spam1=77 ct-spam2=8 ct-bulk=5 rcpts=1 size=829 X-Sendmail-CM-Score: 0.00% X-Sendmail-CM-Analysis: v=2.1 cv=aMPJ99Nm c=1 sm=1 tr=0 a=ZEjyMTgO99znwcqTS+wwQw==:117 a=f0PyeID7pTB3J9tuhFYY4w==:17 a=LcaDllckn3IA:10 a=hU9nTfHc5D4A:10 a=nDghuxUhq_wA:10 a=wPDyFdB5xvgA:10 a=kj9zAlcOel0A:10 a=pGLkceISAAAA:8 a=1XWaLZrsAAAA:8 a=ksf1kCOEe5HeqwTQDa IA:9 a=CjuIK1q_8ugA:10 a=MSl-tDqOz04A:10 X-Sendmail-CT-RefID: str=0001.0A090203.53D66BB0.019C, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-Sendmail-CT-Classification: not spam X-Mailman-Approved-At: Tue, 12 Aug 2014 09:10:26 -0700 Cc: julia.lawall@lip6.fr Subject: [Ocfs2-devel] [PATCH] ocfs2: delete double assignment X-BeenThere: ocfs2-devel@oss.oracle.com X-Mailman-Version: 2.1.9 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: ocfs2-devel-bounces@oss.oracle.com Errors-To: ocfs2-devel-bounces@oss.oracle.com X-Source-IP: acsinet22.oracle.com [141.146.126.238] X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, FREEMAIL_FROM,RCVD_IN_DNSWL_MED,RP_MATCHES_RCVD,UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Delete successive assignments to the same location. The two assignments are simply identical. A simplified version of Coccinelle semantic match that finds this problem is as follows: // @@ expression i; @@ *i = ...; i = ...; // Signed-off-by: Himangi Saraogi --- Should the fist assignment be initializing the pv_minor field? fs/ocfs2/stack_user.c | 1 - 1 file changed, 1 deletion(-) diff --git a/fs/ocfs2/stack_user.c b/fs/ocfs2/stack_user.c index 13a8537..4bcbb9b 100644 --- a/fs/ocfs2/stack_user.c +++ b/fs/ocfs2/stack_user.c @@ -591,7 +591,6 @@ static int ocfs2_control_release(struct inode *inode, struct file *file) */ ocfs2_control_this_node = -1; running_proto.pv_major = 0; - running_proto.pv_major = 0; } out: