| Message ID | 20230803145417.177649-1-artem.chernyshev@red-soft.ru (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | fs: ocfs2: namei: Check return value of ocfs2_add_entry() | expand |
On 8/3/23 10:54 PM, Artem Chernyshev wrote: > Process result of ocfs2_add_entry() in case we have an error > value. > > Found by Linux Verification Center (linuxtesting.org) with SVACE. > > Fixes: ccd979bdbce9 ("[PATCH] OCFS2: The Second Oracle Cluster Filesystem") > Signed-off-by: Artem Chernyshev <artem.chernyshev@red-soft.ru> Reviewed-by: Joseph Qi <joseph.qi@linux.alibaba.com> > --- > fs/ocfs2/namei.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/fs/ocfs2/namei.c b/fs/ocfs2/namei.c > index 17c52225b87d..03bccfd183f3 100644 > --- a/fs/ocfs2/namei.c > +++ b/fs/ocfs2/namei.c > @@ -1535,6 +1535,10 @@ static int ocfs2_rename(struct mnt_idmap *idmap, > status = ocfs2_add_entry(handle, new_dentry, old_inode, > OCFS2_I(old_inode)->ip_blkno, > new_dir_bh, &target_insert); > + if (status < 0) { > + mlog_errno(status); > + goto bail; > + } > } > > old_inode->i_ctime = current_time(old_inode);
diff --git a/fs/ocfs2/namei.c b/fs/ocfs2/namei.c index 17c52225b87d..03bccfd183f3 100644 --- a/fs/ocfs2/namei.c +++ b/fs/ocfs2/namei.c @@ -1535,6 +1535,10 @@ static int ocfs2_rename(struct mnt_idmap *idmap, status = ocfs2_add_entry(handle, new_dentry, old_inode, OCFS2_I(old_inode)->ip_blkno, new_dir_bh, &target_insert); + if (status < 0) { + mlog_errno(status); + goto bail; + } } old_inode->i_ctime = current_time(old_inode);
Process result of ocfs2_add_entry() in case we have an error value. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: ccd979bdbce9 ("[PATCH] OCFS2: The Second Oracle Cluster Filesystem") Signed-off-by: Artem Chernyshev <artem.chernyshev@red-soft.ru> --- fs/ocfs2/namei.c | 4 ++++ 1 file changed, 4 insertions(+)