| Message ID | 20230919045135.3635437-16-willy@infradead.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Finish the create_empty_buffers() transition | expand |
On Tue, Sep 19, 2023 at 3:47 PM Matthew Wilcox (Oracle) wrote: > > This function was already using a folio, so this update to the new API > removes a single folio->page->folio conversion. > > Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org> > --- > fs/nilfs2/segment.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/fs/nilfs2/segment.c b/fs/nilfs2/segment.c > index 7ec16879756e..94388fe83cf8 100644 > --- a/fs/nilfs2/segment.c > +++ b/fs/nilfs2/segment.c > @@ -731,10 +731,9 @@ static size_t nilfs_lookup_dirty_data_buffers(struct inode *inode, > continue; > } > head = folio_buffers(folio); > - if (!head) { > - create_empty_buffers(&folio->page, i_blocksize(inode), 0); > - head = folio_buffers(folio); > - } > + if (!head) > + head = folio_create_empty_buffers(folio, > + i_blocksize(inode), 0); > folio_unlock(folio); > > bh = head; > -- > 2.40.1 > Acked-by: Ryusuke Konishi <konishi.ryusuke@gmail.com> Now, I've seen all the changes to nilfs2 including the last patch. It's almost a direct conversion throughout, and I don't see any issues with the nilfs2 part other than the build issue. With all 26 patches applied, nilfs2 is running without problems in actual machine tests including stress tests. Thank you very much for your efforts. Regards, Ryusuke Konishi
diff --git a/fs/nilfs2/segment.c b/fs/nilfs2/segment.c index 7ec16879756e..94388fe83cf8 100644 --- a/fs/nilfs2/segment.c +++ b/fs/nilfs2/segment.c @@ -731,10 +731,9 @@ static size_t nilfs_lookup_dirty_data_buffers(struct inode *inode, continue; } head = folio_buffers(folio); - if (!head) { - create_empty_buffers(&folio->page, i_blocksize(inode), 0); - head = folio_buffers(folio); - } + if (!head) + head = folio_create_empty_buffers(folio, + i_blocksize(inode), 0); folio_unlock(folio); bh = head;
This function was already using a folio, so this update to the new API removes a single folio->page->folio conversion. Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org> --- fs/nilfs2/segment.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)