| Message ID | 20240423223018.1573213-1-colin.i.king@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [next] ocfs2: remove redundant assignment to variable status | expand |
On 4/24/24 06:30, Colin Ian King wrote: > Variable status is being assigned and error code that is never read, it is > being assigned inside of a do-while loop. The assignment is redundant and > can be removed. > > Cleans up clang scan build warning: > fs/ocfs2/dlm/dlmdomain.c:1530:2: warning: Value stored to 'status' is never > read [deadcode.DeadStores] > > Signed-off-by: Colin Ian King <colin.i.king@gmail.com> > --- > fs/ocfs2/dlm/dlmdomain.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/fs/ocfs2/dlm/dlmdomain.c b/fs/ocfs2/dlm/dlmdomain.c > index 2e0a2f338282..2018501b2249 100644 > --- a/fs/ocfs2/dlm/dlmdomain.c > +++ b/fs/ocfs2/dlm/dlmdomain.c > @@ -1527,7 +1527,6 @@ static void dlm_send_join_asserts(struct dlm_ctxt *dlm, > { > int status, node, live; > > - status = 0; > node = -1; > while ((node = find_next_bit(node_map, O2NM_MAX_NODES, > node + 1)) < O2NM_MAX_NODES) { This mail cc linux-kernel@vger.kernel.org, it would be better to only cc ocfs2-devel next time. This patch is correct, but it's a very trivial fix. I am not sure if Joseph is willing to take time to push to mainline kernel. Thanks, Heming
On 4/24/24 6:30 AM, Colin Ian King wrote: > Variable status is being assigned and error code that is never read, it is > being assigned inside of a do-while loop. The assignment is redundant and > can be removed. > > Cleans up clang scan build warning: > fs/ocfs2/dlm/dlmdomain.c:1530:2: warning: Value stored to 'status' is never > read [deadcode.DeadStores] > > Signed-off-by: Colin Ian King <colin.i.king@gmail.com> Acked-by: Joseph Qi <joseph.qi@linux.alibaba.com> > --- > fs/ocfs2/dlm/dlmdomain.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/fs/ocfs2/dlm/dlmdomain.c b/fs/ocfs2/dlm/dlmdomain.c > index 2e0a2f338282..2018501b2249 100644 > --- a/fs/ocfs2/dlm/dlmdomain.c > +++ b/fs/ocfs2/dlm/dlmdomain.c > @@ -1527,7 +1527,6 @@ static void dlm_send_join_asserts(struct dlm_ctxt *dlm, > { > int status, node, live; > > - status = 0; > node = -1; > while ((node = find_next_bit(node_map, O2NM_MAX_NODES, > node + 1)) < O2NM_MAX_NODES) {
On Wed, Apr 24, 2024 at 09:40:33AM +0800, Heming Zhao wrote: > On 4/24/24 06:30, Colin Ian King wrote: > > Variable status is being assigned and error code that is never read, it is > > being assigned inside of a do-while loop. The assignment is redundant and > > can be removed. > > > > Cleans up clang scan build warning: > > fs/ocfs2/dlm/dlmdomain.c:1530:2: warning: Value stored to 'status' is never > > read [deadcode.DeadStores] > > > > Signed-off-by: Colin Ian King <colin.i.king@gmail.com> > > --- > > fs/ocfs2/dlm/dlmdomain.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/fs/ocfs2/dlm/dlmdomain.c b/fs/ocfs2/dlm/dlmdomain.c > > index 2e0a2f338282..2018501b2249 100644 > > --- a/fs/ocfs2/dlm/dlmdomain.c > > +++ b/fs/ocfs2/dlm/dlmdomain.c > > @@ -1527,7 +1527,6 @@ static void dlm_send_join_asserts(struct dlm_ctxt *dlm, > > { > > int status, node, live; > > - status = 0; > > node = -1; > > while ((node = find_next_bit(node_map, O2NM_MAX_NODES, > > node + 1)) < O2NM_MAX_NODES) { > > This mail cc linux-kernel@vger.kernel.org, it would be better to only > cc ocfs2-devel next time. I used to tell people that, but Linus Torvalds disagreed with me. I also used to filter LKML from my own patches but then I ran into the issue where a couple subsystems use LKML as a source for patchwork and they get annoyed when it's not on the CC list. In one of the threads for last year's kernel summit people said you should just use get_maintainer.pl and keep LKML on the CC list. So I think that is the rule now. Except for maybe in networking. I still edit the CC lists there. regards, dan carpenter
diff --git a/fs/ocfs2/dlm/dlmdomain.c b/fs/ocfs2/dlm/dlmdomain.c index 2e0a2f338282..2018501b2249 100644 --- a/fs/ocfs2/dlm/dlmdomain.c +++ b/fs/ocfs2/dlm/dlmdomain.c @@ -1527,7 +1527,6 @@ static void dlm_send_join_asserts(struct dlm_ctxt *dlm, { int status, node, live; - status = 0; node = -1; while ((node = find_next_bit(node_map, O2NM_MAX_NODES, node + 1)) < O2NM_MAX_NODES) {
Variable status is being assigned and error code that is never read, it is being assigned inside of a do-while loop. The assignment is redundant and can be removed. Cleans up clang scan build warning: fs/ocfs2/dlm/dlmdomain.c:1530:2: warning: Value stored to 'status' is never read [deadcode.DeadStores] Signed-off-by: Colin Ian King <colin.i.king@gmail.com> --- fs/ocfs2/dlm/dlmdomain.c | 1 - 1 file changed, 1 deletion(-)