| Message ID | 20240718021842.7595-1-heming.zhao@suse.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [v2] ocfs2: fix the la space leak when unmounting an ocfs2 volume | expand |
On 7/18/24 10:18 AM, Heming Zhao wrote: > This bug has existed since the initial OCFS2 code. The code logic > in ocfs2_sync_local_to_main() is wrong, as it ignores the last > contiguous free bits, which causes an OCFS2 volume to lose the > LA window size space on each umount command. > It only ignore the last few clusters, but not the whole la window. Thanks, Joseph > Signed-off-by: Heming Zhao <heming.zhao@suse.com> > Reviewed-by: Su Yue <glass.su@suse.com> > --- > v1 -> v2: adjust 'if' condition to make the code logic more concise > --- > fs/ocfs2/localalloc.c | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > diff --git a/fs/ocfs2/localalloc.c b/fs/ocfs2/localalloc.c > index 5df34561c551..8ac42ea81a17 100644 > --- a/fs/ocfs2/localalloc.c > +++ b/fs/ocfs2/localalloc.c > @@ -1002,6 +1002,25 @@ static int ocfs2_sync_local_to_main(struct ocfs2_super *osb, > start = bit_off + 1; > } > > + /* clear the contiguous bits until the end boundary */ > + if (count) { > + blkno = la_start_blk + > + ocfs2_clusters_to_blocks(osb->sb, > + start - count); > + > + trace_ocfs2_sync_local_to_main_free( > + count, start - count, > + (unsigned long long)la_start_blk, > + (unsigned long long)blkno); > + > + status = ocfs2_release_clusters(handle, > + main_bm_inode, > + main_bm_bh, blkno, > + count); > + if (status < 0) > + mlog_errno(status); > + } > + > bail: > if (status) > mlog_errno(status);
On 7/19/24 16:52, Joseph Qi wrote: > > > On 7/18/24 10:18 AM, Heming Zhao wrote: >> This bug has existed since the initial OCFS2 code. The code logic >> in ocfs2_sync_local_to_main() is wrong, as it ignores the last >> contiguous free bits, which causes an OCFS2 volume to lose the >> LA window size space on each umount command. >> > It only ignore the last few clusters, but not the whole la window. > > Thanks, > Joseph Yes, I will revise the commit log. -Heming > >> Signed-off-by: Heming Zhao <heming.zhao@suse.com> >> Reviewed-by: Su Yue <glass.su@suse.com> >> --- >> v1 -> v2: adjust 'if' condition to make the code logic more concise >> --- >> fs/ocfs2/localalloc.c | 19 +++++++++++++++++++ >> 1 file changed, 19 insertions(+) >> >> diff --git a/fs/ocfs2/localalloc.c b/fs/ocfs2/localalloc.c >> index 5df34561c551..8ac42ea81a17 100644 >> --- a/fs/ocfs2/localalloc.c >> +++ b/fs/ocfs2/localalloc.c >> @@ -1002,6 +1002,25 @@ static int ocfs2_sync_local_to_main(struct ocfs2_super *osb, >> start = bit_off + 1; >> } >> >> + /* clear the contiguous bits until the end boundary */ >> + if (count) { >> + blkno = la_start_blk + >> + ocfs2_clusters_to_blocks(osb->sb, >> + start - count); >> + >> + trace_ocfs2_sync_local_to_main_free( >> + count, start - count, >> + (unsigned long long)la_start_blk, >> + (unsigned long long)blkno); >> + >> + status = ocfs2_release_clusters(handle, >> + main_bm_inode, >> + main_bm_bh, blkno, >> + count); >> + if (status < 0) >> + mlog_errno(status); >> + } >> + >> bail: >> if (status) >> mlog_errno(status); >
diff --git a/fs/ocfs2/localalloc.c b/fs/ocfs2/localalloc.c index 5df34561c551..8ac42ea81a17 100644 --- a/fs/ocfs2/localalloc.c +++ b/fs/ocfs2/localalloc.c @@ -1002,6 +1002,25 @@ static int ocfs2_sync_local_to_main(struct ocfs2_super *osb, start = bit_off + 1; } + /* clear the contiguous bits until the end boundary */ + if (count) { + blkno = la_start_blk + + ocfs2_clusters_to_blocks(osb->sb, + start - count); + + trace_ocfs2_sync_local_to_main_free( + count, start - count, + (unsigned long long)la_start_blk, + (unsigned long long)blkno); + + status = ocfs2_release_clusters(handle, + main_bm_inode, + main_bm_bh, blkno, + count); + if (status < 0) + mlog_errno(status); + } + bail: if (status) mlog_errno(status);