| Message ID | 20241119174500.9198-1-wen.gang.wang@oracle.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | ocfs2: update seq_file index in ocfs2_dlm_seq_next V2 | expand |
On 11/20/24 1:45 AM, Wengang Wang wrote: > The following INFO level message was seen: > > seq_file: buggy .next function ocfs2_dlm_seq_next [ocfs2] did not > update position index > > Fix: > Update *pos (so m->index) to make seq_read_iter happy though the index its > self makes no sense to ocfs2_dlm_seq_next. > > Signed-off-by: Wengang Wang <wen.gang.wang@oracle.com> Reviewed-by: Joseph Qi <joseph.qi@linux.alibaba.com> > --- > fs/ocfs2/dlmglue.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/fs/ocfs2/dlmglue.c b/fs/ocfs2/dlmglue.c > index 60df52e4c1f8..764ecbd5ad41 100644 > --- a/fs/ocfs2/dlmglue.c > +++ b/fs/ocfs2/dlmglue.c > @@ -3110,6 +3110,7 @@ static void *ocfs2_dlm_seq_next(struct seq_file *m, void *v, loff_t *pos) > struct ocfs2_lock_res *iter = v; > struct ocfs2_lock_res *dummy = &priv->p_iter_res; > > + (*pos)++; > spin_lock(&ocfs2_dlm_tracking_lock); > iter = ocfs2_dlm_next_res(iter, priv); > list_del_init(&dummy->l_debug_list);
diff --git a/fs/ocfs2/dlmglue.c b/fs/ocfs2/dlmglue.c index 60df52e4c1f8..764ecbd5ad41 100644 --- a/fs/ocfs2/dlmglue.c +++ b/fs/ocfs2/dlmglue.c @@ -3110,6 +3110,7 @@ static void *ocfs2_dlm_seq_next(struct seq_file *m, void *v, loff_t *pos) struct ocfs2_lock_res *iter = v; struct ocfs2_lock_res *dummy = &priv->p_iter_res; + (*pos)++; spin_lock(&ocfs2_dlm_tracking_lock); iter = ocfs2_dlm_next_res(iter, priv); list_del_init(&dummy->l_debug_list);
The following INFO level message was seen: seq_file: buggy .next function ocfs2_dlm_seq_next [ocfs2] did not update position index Fix: Update *pos (so m->index) to make seq_read_iter happy though the index its self makes no sense to ocfs2_dlm_seq_next. Signed-off-by: Wengang Wang <wen.gang.wang@oracle.com> --- fs/ocfs2/dlmglue.c | 1 + 1 file changed, 1 insertion(+)