Message ID | 20250106140634.92241-1-glass.su@suse.com (mailing list archive) |
---|---|
State | New |
Headers | show |
Series | ocfs2: remove parameter parent_fe_bh from __ocfs2_mknod_locked | expand |
On 2025/1/6 22:06, Su Yue wrote: > The parameter is not used in __ocfs2_mknod_locked(). So remove > it. > > No functional change. > > Signed-off-by: Su Yue <glass.su@suse.com> Looks good. Reviewed-by: Joseph Qi <joseph.qi@linux.alibaba.com> > --- > fs/ocfs2/namei.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/fs/ocfs2/namei.c b/fs/ocfs2/namei.c > index 5550f8afa438..0ec63a1a94b8 100644 > --- a/fs/ocfs2/namei.c > +++ b/fs/ocfs2/namei.c > @@ -508,7 +508,6 @@ static int __ocfs2_mknod_locked(struct inode *dir, > struct inode *inode, > dev_t dev, > struct buffer_head **new_fe_bh, > - struct buffer_head *parent_fe_bh, > handle_t *handle, > struct ocfs2_alloc_context *inode_ac, > u64 fe_blkno, u64 suballoc_loc, u16 suballoc_bit) > @@ -641,8 +640,8 @@ static int ocfs2_mknod_locked(struct ocfs2_super *osb, > } > > return __ocfs2_mknod_locked(dir, inode, dev, new_fe_bh, > - parent_fe_bh, handle, inode_ac, > - fe_blkno, suballoc_loc, suballoc_bit); > + handle, inode_ac, fe_blkno, > + suballoc_loc, suballoc_bit); > } > > static int ocfs2_mkdir(struct mnt_idmap *idmap, > @@ -2576,7 +2575,7 @@ int ocfs2_create_inode_in_orphan(struct inode *dir, > clear_nlink(inode); > /* do the real work now. */ > status = __ocfs2_mknod_locked(dir, inode, > - 0, &new_di_bh, parent_di_bh, handle, > + 0, &new_di_bh, handle, > inode_ac, di_blkno, suballoc_loc, > suballoc_bit); > if (status < 0) {
diff --git a/fs/ocfs2/namei.c b/fs/ocfs2/namei.c index 5550f8afa438..0ec63a1a94b8 100644 --- a/fs/ocfs2/namei.c +++ b/fs/ocfs2/namei.c @@ -508,7 +508,6 @@ static int __ocfs2_mknod_locked(struct inode *dir, struct inode *inode, dev_t dev, struct buffer_head **new_fe_bh, - struct buffer_head *parent_fe_bh, handle_t *handle, struct ocfs2_alloc_context *inode_ac, u64 fe_blkno, u64 suballoc_loc, u16 suballoc_bit) @@ -641,8 +640,8 @@ static int ocfs2_mknod_locked(struct ocfs2_super *osb, } return __ocfs2_mknod_locked(dir, inode, dev, new_fe_bh, - parent_fe_bh, handle, inode_ac, - fe_blkno, suballoc_loc, suballoc_bit); + handle, inode_ac, fe_blkno, + suballoc_loc, suballoc_bit); } static int ocfs2_mkdir(struct mnt_idmap *idmap, @@ -2576,7 +2575,7 @@ int ocfs2_create_inode_in_orphan(struct inode *dir, clear_nlink(inode); /* do the real work now. */ status = __ocfs2_mknod_locked(dir, inode, - 0, &new_di_bh, parent_di_bh, handle, + 0, &new_di_bh, handle, inode_ac, di_blkno, suballoc_loc, suballoc_bit); if (status < 0) {
The parameter is not used in __ocfs2_mknod_locked(). So remove it. No functional change. Signed-off-by: Su Yue <glass.su@suse.com> --- fs/ocfs2/namei.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)