| Message ID | 51FB7876.1010506@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 08/02/2013 05:14 PM, Younger Liu wrote: > In ocfs2_remove_inode_range(), there is a memory leak. > The variable path has allocated memory with ocfs2_new_path_from_et(), > but it is not free. > > Signed-off-by: Younger Liu <younger.liu@huawei.com> > --- > fs/ocfs2/file.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/fs/ocfs2/file.c b/fs/ocfs2/file.c > index 833a09b..2d1a227 100644 > --- a/fs/ocfs2/file.c > +++ b/fs/ocfs2/file.c > @@ -1796,6 +1796,7 @@ static int ocfs2_remove_inode_range(struct inode *inode, > ocfs2_truncate_cluster_pages(inode, byte_start, byte_len); > > out: > + ocfs2_free_path(path); > ocfs2_schedule_truncate_log_flush(osb, 1); > ocfs2_run_deallocs(osb, &dealloc); This patch looks good to me. Reviewed-by: Jie Liu <jeff.liu@oracle.com> BTW, I found another similar problem at: ocfs2/move_extent.c->__ocfs2_move_extent() with a simple `grep` against the source tree, will post a patch to fix it, would you like to help review? Thanks, -Jeff
diff --git a/fs/ocfs2/file.c b/fs/ocfs2/file.c index 833a09b..2d1a227 100644 --- a/fs/ocfs2/file.c +++ b/fs/ocfs2/file.c @@ -1796,6 +1796,7 @@ static int ocfs2_remove_inode_range(struct inode *inode, ocfs2_truncate_cluster_pages(inode, byte_start, byte_len); out: + ocfs2_free_path(path); ocfs2_schedule_truncate_log_flush(osb, 1); ocfs2_run_deallocs(osb, &dealloc);
In ocfs2_remove_inode_range(), there is a memory leak. The variable path has allocated memory with ocfs2_new_path_from_et(), but it is not free. Signed-off-by: Younger Liu <younger.liu@huawei.com> --- fs/ocfs2/file.c | 1 + 1 file changed, 1 insertion(+)