diff mbox

ocfs2: fix a memory leak at __ocfs2_move_extents()

Message ID 5200968A.1050403@oracle.com (mailing list archive)
State New, archived
Headers show

Commit Message

jeff.liu Aug. 6, 2013, 6:24 a.m. UTC 
From: Jie Liu <jeff.liu@oracle.com>

The ocfs2 path is not properly freed which leads to a
memory leak at __ocfs2_move_extents().

This patch stops the leaks of the ocfs2_path structure.

Cc: Younger Liu <younger.liu@huawei.com>
Signed-off-by: Jie Liu <jeff.liu@oracle.com>
---
 fs/ocfs2/move_extents.c |    1 +
 1 file changed, 1 insertion(+)

Comments

Younger Liu Aug. 6, 2013, 8:39 a.m. UTC | #1 
On 2013/8/6 14:24, Jeff Liu wrote:
> From: Jie Liu <jeff.liu@oracle.com>
> 
> The ocfs2 path is not properly freed which leads to a
> memory leak at __ocfs2_move_extents().
> 
> This patch stops the leaks of the ocfs2_path structure.
> 
> Cc: Younger Liu <younger.liu@huawei.com>
> Signed-off-by: Jie Liu <jeff.liu@oracle.com>

This patch looks fine to me.
Reviewed-by: Younger Liu <younger.liu@huawei.com>

> ---
>  fs/ocfs2/move_extents.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/fs/ocfs2/move_extents.c b/fs/ocfs2/move_extents.c
> index f1fc172..37231d1 100644
> --- a/fs/ocfs2/move_extents.c
> +++ b/fs/ocfs2/move_extents.c
> @@ -152,6 +152,7 @@ static int __ocfs2_move_extent(handle_t *handle,
>  	}
>  
>  out:
> +	ocfs2_free_path(path);
>  	return ret;
>  }
>  
>
diff mbox

Patch

diff --git a/fs/ocfs2/move_extents.c b/fs/ocfs2/move_extents.c
index f1fc172..37231d1 100644
--- a/fs/ocfs2/move_extents.c
+++ b/fs/ocfs2/move_extents.c
@@ -152,6 +152,7 @@  static int __ocfs2_move_extent(handle_t *handle,
 	}
 
 out:
+	ocfs2_free_path(path);
 	return ret;
 }