Message ID | 55de398c.VmwgWKAl9bo0fBBw%akpm@linux-foundation.org (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
On Wed, Aug 26, 2015 at 03:11:24PM -0700, Andrew Morton wrote: > From: Sanidhya Kashyap <sanidhya.gatech@gmail.com> > Subject: ocfs2: trusted xattr missing CAP_SYS_ADMIN check > > The trusted extended attributes are only visible to the process which hvae > CAP_SYS_ADMIN capability but the check is missing in ocfs2 xattr_handler > trusted list. The check is important because this will be used for > implementing mechanisms in the userspace for which other ordinary > processes should not have access to. > > Signed-off-by: Sanidhya Kashyap <sanidhya.gatech@gmail.com> > Cc: Mark Fasheh <mfasheh@suse.com> > Cc: Joel Becker <jlbec@evilplan.org> > Cc: Taesoo kim <taesoo@gatech.edu> > Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Reviewed-by: Mark Fasheh <mfasheh@suse.de> -- Mark Fasheh
diff -puN fs/ocfs2/xattr.c~ocfs2-trusted-xattr-missing-cap_sys_admin-check fs/ocfs2/xattr.c --- a/fs/ocfs2/xattr.c~ocfs2-trusted-xattr-missing-cap_sys_admin-check +++ a/fs/ocfs2/xattr.c @@ -7334,6 +7334,9 @@ static size_t ocfs2_xattr_trusted_list(s const size_t prefix_len = XATTR_TRUSTED_PREFIX_LEN; const size_t total_len = prefix_len + name_len + 1; + if (!capable(CAP_SYS_ADMIN)) + return 0; + if (list && total_len <= list_size) { memcpy(list, XATTR_TRUSTED_PREFIX, prefix_len); memcpy(list + prefix_len, name, name_len);