| Message ID | 5611F380.2050102@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 2015/10/5 11:50, jiangyiwen wrote: > In update_backups func, it exists a problem of crossing the boundary > as follows: > we assume that lun will be resized to 1TB(cluster_size is 32kb), > it will include 0~33554431 cluster, in update_backups func, > it will backup super block in location of 1TB which is the 33554432th > cluster, so the phenomenon of crossing the boundary is happened. > > Signed-off-by: Yiwen Jiang <jiangyiwen@huawei.com> Reviewed-by: Joseph Qi <joseph.qi@huawei.com> > --- > fs/ocfs2/resize.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/ocfs2/resize.c b/fs/ocfs2/resize.c > index d5da6f6..10ad87b 100644 > --- a/fs/ocfs2/resize.c > +++ b/fs/ocfs2/resize.c > @@ -187,7 +187,7 @@ static int update_backups(struct inode * inode, u32 clusters, char *data) > for (i = 0; i < OCFS2_MAX_BACKUP_SUPERBLOCKS; i++) { > blkno = ocfs2_backup_super_blkno(inode->i_sb, i); > cluster = ocfs2_blocks_to_clusters(inode->i_sb, blkno); > - if (cluster > clusters) > + if (cluster >= clusters) > break; > > ret = ocfs2_read_blocks_sync(osb, blkno, 1, &backup); >
diff --git a/fs/ocfs2/resize.c b/fs/ocfs2/resize.c index d5da6f6..10ad87b 100644 --- a/fs/ocfs2/resize.c +++ b/fs/ocfs2/resize.c @@ -187,7 +187,7 @@ static int update_backups(struct inode * inode, u32 clusters, char *data) for (i = 0; i < OCFS2_MAX_BACKUP_SUPERBLOCKS; i++) { blkno = ocfs2_backup_super_blkno(inode->i_sb, i); cluster = ocfs2_blocks_to_clusters(inode->i_sb, blkno); - if (cluster > clusters) + if (cluster >= clusters) break; ret = ocfs2_read_blocks_sync(osb, blkno, 1, &backup);
In update_backups func, it exists a problem of crossing the boundary as follows: we assume that lun will be resized to 1TB(cluster_size is 32kb), it will include 0~33554431 cluster, in update_backups func, it will backup super block in location of 1TB which is the 33554432th cluster, so the phenomenon of crossing the boundary is happened. Signed-off-by: Yiwen Jiang <jiangyiwen@huawei.com> --- fs/ocfs2/resize.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)