diff mbox series

[3/4] smsutil: Check cbs_dcs_decode return value

Message ID 20240229180746.1671015-3-denkenz@gmail.com (mailing list archive)
State Accepted
Commit 7f2adfa22fbae824f8e2c3ae86a3f51da31ee400
Headers show
Series [1/4] voicecall: Drop unused GError variables | expand

Commit Message

Denis Kenzior Feb. 29, 2024, 6:07 p.m. UTC 
It is better to explicitly check the return value of cbs_dcs_decode
instead of relying on udhi not being changed due to side-effects.
---
 src/smsutil.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/src/smsutil.c b/src/smsutil.c
index e89b4567f9f4..6fe2bcb4477f 100644
--- a/src/smsutil.c
+++ b/src/smsutil.c
@@ -1765,7 +1765,8 @@  gboolean sms_udh_iter_init_from_cbs(const struct cbs *cbs,
 	const guint8 *hdr;
 	guint8 max_ud_len;
 
-	cbs_dcs_decode(cbs->dcs, &udhi, NULL, NULL, NULL, NULL, NULL);
+	if (!cbs_dcs_decode(cbs->dcs, &udhi, NULL, NULL, NULL, NULL, NULL))
+		return FALSE;
 
 	if (!udhi)
 		return FALSE;