diff mbox series

[1/3] gobi: Do not wait for timeout to shutdown

Message ID 20240416221233.404872-1-steve.schrock@getcruise.com (mailing list archive)
State Accepted
Commit 580a0c22e5cf757af21b3a66c66c5074766c3504
Headers show
Series [1/3] gobi: Do not wait for timeout to shutdown | expand

Commit Message

Steve Schrock April 16, 2024, 10:12 p.m. UTC
Now the qmi_device_shutdown() function can return a failure. It will
do this if the qmi_device type does not support shutdown. When this
happens gobi should immediately proceed with shutdown instead of
waiting until the timeout occurs.
---
 plugins/gobi.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

patchwork-bot+ofono@kernel.org April 17, 2024, 3:40 p.m. UTC | #1
Hello:

This series was applied to ofono.git (master)
by Denis Kenzior <denkenz@gmail.com>:

On Tue, 16 Apr 2024 22:12:31 +0000 you wrote:
> Now the qmi_device_shutdown() function can return a failure. It will
> do this if the qmi_device type does not support shutdown. When this
> happens gobi should immediately proceed with shutdown instead of
> waiting until the timeout occurs.
> ---
>  plugins/gobi.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Here is the summary with links:
  - [1/3] gobi: Do not wait for timeout to shutdown
    https://git.kernel.org/pub/scm/network/ofono/ofono.git/?id=580a0c22e5cf
  - [2/3] qmi unit: Make test service sends more generic
    https://git.kernel.org/pub/scm/network/ofono/ofono.git/?id=c39ddccf761b
  - [3/3] qmi unit: Add notification registration test
    https://git.kernel.org/pub/scm/network/ofono/ofono.git/?id=c3313629276f

You are awesome, thank you!
diff mbox series

Patch

diff --git a/plugins/gobi.c b/plugins/gobi.c
index 431df17e2332..9ab561010912 100644
--- a/plugins/gobi.c
+++ b/plugins/gobi.c
@@ -174,7 +174,8 @@  static void shutdown_device(struct ofono_modem *modem)
 
 	cleanup_services(data);
 
-	qmi_device_shutdown(data->device, shutdown_cb, modem, NULL);
+	if (qmi_device_shutdown(data->device, shutdown_cb, modem, NULL) < 0)
+		shutdown_cb(modem);
 }
 
 static void power_reset_cb(struct qmi_result *result, void *user_data)