| Message ID | 20240527105915.637532-1-martin@geanix.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | atmodem: gprs-context: use default PPP ACCM for Quectel serial modems | expand |
Hi Martin, On 5/27/24 5:59 AM, Martin Hundebøll wrote: > Since commit c8ed7162 ("ppp: using RX ACCM = 0 by default"), the Quectel > M95 modem has failed to establish a PPP context. Instead, it > continuously logs this: > PPP: event: 9 (RCN), action: 1028, new_state: 8 (ACKSENT) > PPP: lcp: pppcp_initialize_restart_count: current state 8:ACKSENT > PPP: lcp: pppcp_send_configure_request: current state 8:ACKSENT > PPP: lcp: pppcp_process_configure_nak: current state 8:ACKSENT > PPP: lcp: pppcp_generate_event: current state 8:ACKSENT > > Restore PPP functionality by configuring the (protocol) default ACCM > value of 0x000a0000. > --- > drivers/atmodem/gprs-context.c | 5 +++++ > 1 file changed, 5 insertions(+) > Could you please add: [core] abbrev = 12 to your .git/config? Otherwise CI complains: 0001-atmodem-gprs-context-use-default-PPP-ACCM-for-Quecte.patch:7: ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 0123456789ab ("ppp: using RX ACCM = 0 by default")' > diff --git a/drivers/atmodem/gprs-context.c b/drivers/atmodem/gprs-context.c > index bfe6ae56..0baea4a1 100644 > --- a/drivers/atmodem/gprs-context.c > +++ b/drivers/atmodem/gprs-context.c > @@ -163,6 +163,11 @@ static gboolean setup_ppp(struct ofono_gprs_context *gc) > g_at_ppp_set_credentials(gcd->ppp, gcd->username, > gcd->password); > > + /* Quectel M95 fails to configure RCN when using ACCM = 0, so set it to > + * the protocol default of 0x000a0000. */ Multi-line comments should look like this: /* * Line 1 * Line 2 */ > + if (gcd->vendor == OFONO_VENDOR_QUECTEL_SERIAL) > + g_at_ppp_set_accm(gcd->ppp, 0x000a0000); > + > /* set connect and disconnect callbacks */ > g_at_ppp_set_connect_function(gcd->ppp, ppp_connect, gc); > g_at_ppp_set_disconnect_function(gcd->ppp, ppp_disconnect, gc); I fixed both issues and applied, thanks. Regards, -Denis
diff --git a/drivers/atmodem/gprs-context.c b/drivers/atmodem/gprs-context.c index bfe6ae56..0baea4a1 100644 --- a/drivers/atmodem/gprs-context.c +++ b/drivers/atmodem/gprs-context.c @@ -163,6 +163,11 @@ static gboolean setup_ppp(struct ofono_gprs_context *gc) g_at_ppp_set_credentials(gcd->ppp, gcd->username, gcd->password); + /* Quectel M95 fails to configure RCN when using ACCM = 0, so set it to + * the protocol default of 0x000a0000. */ + if (gcd->vendor == OFONO_VENDOR_QUECTEL_SERIAL) + g_at_ppp_set_accm(gcd->ppp, 0x000a0000); + /* set connect and disconnect callbacks */ g_at_ppp_set_connect_function(gcd->ppp, ppp_connect, gc); g_at_ppp_set_disconnect_function(gcd->ppp, ppp_disconnect, gc);
Since commit c8ed7162 ("ppp: using RX ACCM = 0 by default"), the Quectel M95 modem has failed to establish a PPP context. Instead, it continuously logs this: PPP: event: 9 (RCN), action: 1028, new_state: 8 (ACKSENT) PPP: lcp: pppcp_initialize_restart_count: current state 8:ACKSENT PPP: lcp: pppcp_send_configure_request: current state 8:ACKSENT PPP: lcp: pppcp_process_configure_nak: current state 8:ACKSENT PPP: lcp: pppcp_generate_event: current state 8:ACKSENT Restore PPP functionality by configuring the (protocol) default ACCM value of 0x000a0000. --- drivers/atmodem/gprs-context.c | 5 +++++ 1 file changed, 5 insertions(+)