Revert "sim7100: create lte atom in post_sim()"

Commit Message

Sean Nyekjaer Oct. 25, 2024, 5:55 a.m. UTC

SIMCom A7672E-FASE doesn't support initial PDP context (AT+CGAUTH=0,...
and AT+CGDCONT=0,...) which is what the lte atom is enables.

This reverts commit 8869b39c1e3a1b76637ffb13fc5de800d7f88c2c.
---
Kinda embarrassing sorry :)

 plugins/sim7100.c | 7 -------
 1 file changed, 7 deletions(-)

Comments

[e-mail] Oct. 28, 2024, 6:30 p.m. UTC | #1

Hello:

This patch was applied to ofono.git (master)
by Denis Kenzior <[e-mail]>:

On Fri, 25 Oct 2024 07:55:56 +0200 you wrote:
> SIMCom A7672E-FASE doesn't support initial PDP context (AT+CGAUTH=0,...
> and AT+CGDCONT=0,...) which is what the lte atom is enables.
> 
> This reverts commit 8869b39c1e3a1b76637ffb13fc5de800d7f88c2c.
> ---
> Kinda embarrassing sorry :)
> 
> [...]

Here is the summary with links:
  - Revert "sim7100: create lte atom in post_sim()"
    https://git.kernel.org/pub/scm/network/ofono/ofono.git/?id=0a2a43a39bf7

You are awesome, thank you!

Patch

diff --git a/plugins/sim7100.c b/plugins/sim7100.c
index 215f4a28..b6389b09 100644
--- a/plugins/sim7100.c
+++ b/plugins/sim7100.c
@@ -24,7 +24,6 @@ 
 #include <gattty.h>
 
 #define OFONO_API_SUBJECT_TO_CHANGE
-#include <ofono.h>
 #include <ofono/plugin.h>
 #include <ofono/log.h>
 #include <ofono/modem.h>
@@ -105,13 +104,9 @@  static void sim7100_remove(struct ofono_modem *modem)
 static void cfun_set_on_cb(gboolean ok, GAtResult *result, gpointer user_data)
 {
 	struct ofono_modem *modem = user_data;
-	struct sim7100_data *data = ofono_modem_get_data(modem);
 
 	DBG("");
 
-	if (data->model == SIMCOM_A76XX)
-		ofono_modem_set_capabilities(modem, OFONO_MODEM_CAPABILITY_LTE);
-
 	if (ok)
 		ofono_modem_set_powered(modem, TRUE);
 }
@@ -277,8 +272,6 @@  static void sim7100_post_sim(struct ofono_modem *modem)
 		ofono_radio_settings_create(modem, 0, "simcommodem", data->at);
 		gprs = ofono_gprs_create(modem, OFONO_VENDOR_SIMCOM_A76XX,
 							"atmodem", data->at);
-		ofono_lte_create(modem, OFONO_VENDOR_SIMCOM_A76XX,
-							"atmodem", data->at);
 		break;
 	default:
 		ofono_netreg_create(modem, 0, "atmodem", data->at);