| Message ID | 20241026115324.211317-1-absicsz@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 116b6dfef7a7a4cfffaf3d02e713baa232195c73 |
| Headers | show |
| Series | udevng: restore support for phonet modems | expand |
Hello: This patch was applied to ofono.git (master) by Denis Kenzior <denkenz@gmail.com>: On Sat, 26 Oct 2024 13:53:11 +0200 you wrote: > Commit 296347f8a4f1 ("udevng: Detect embedded qmi QRTR modems") introduced > a constraint that only rmnet_* modems are valid "net" subsystem devices, thus > breaking phonet modems, which are located in that subsystem as well. > > P: /devices/platform/68000000.ocp/48058000.ssi-controller/ssi0/port0/ssi-protocol/net/phonet0 > E: DEVPATH=/devices/platform/68000000.ocp/48058000.ssi-controller/ssi0/port0/ssi-protocol/net/phonet0 > E: INTERFACE=phonet0 > E: OFONO_DRIVER=n900 > E: OFONO_ISI_ADDRESS=108 > E: SUBSYSTEM=net > > [...] Here is the summary with links: - udevng: restore support for phonet modems https://git.kernel.org/pub/scm/network/ofono/ofono.git/?id=116b6dfef7a7 You are awesome, thank you!
diff --git a/plugins/udevng.c b/plugins/udevng.c index f4266f39..f34cdcb7 100644 --- a/plugins/udevng.c +++ b/plugins/udevng.c @@ -2455,6 +2455,10 @@ static void check_net_device(struct udev_device *device) } name = udev_device_get_sysname(device); + if (l_str_has_prefix(name, "phonet")) { + add_serial_device(device); + return; + } if (!l_str_has_prefix(name, "rmnet_")) return;
Commit 296347f8a4f1 ("udevng: Detect embedded qmi QRTR modems") introduced a constraint that only rmnet_* modems are valid "net" subsystem devices, thus breaking phonet modems, which are located in that subsystem as well. P: /devices/platform/68000000.ocp/48058000.ssi-controller/ssi0/port0/ssi-protocol/net/phonet0 E: DEVPATH=/devices/platform/68000000.ocp/48058000.ssi-controller/ssi0/port0/ssi-protocol/net/phonet0 E: INTERFACE=phonet0 E: OFONO_DRIVER=n900 E: OFONO_ISI_ADDRESS=108 E: SUBSYSTEM=net Fix the regression by specifically checking for phonet inside check_net_device(). Fixes: 296347f8a4f1 ("udevng: Detect embedded qmi QRTR modems") --- plugins/udevng.c | 4 ++++ 1 file changed, 4 insertions(+)