diff mbox series

qmi: gprs: query for tethered default profile instead of embedded

Message ID 20241207183551.198810-1-ivo.g.dimitrov.75@gmail.com (mailing list archive)
State Changes Requested
Headers show
Series qmi: gprs: query for tethered default profile instead of embedded | expand

Commit Message

Ivaylo Dimitrov Dec. 7, 2024, 6:35 p.m. UTC
At least the modem in Motorola Droid 4 returns error if embedded 3gpp
profile is queried, however, it does not error if tethered one is used.
qmicli uses same when doing --wds-get-default-profile-number=3gpp
---
 drivers/qmimodem/gprs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Denis Kenzior Dec. 11, 2024, 5:49 a.m. UTC | #1
Hi Ivo,

On 12/7/24 12:35 PM, Ivaylo Dimitrov wrote:
> At least the modem in Motorola Droid 4 returns error if embedded 3gpp
> profile is queried, however, it does not error if tethered one is used.
> qmicli uses same when doing --wds-get-default-profile-number=3gpp

Okay, but what about lte.c that does the same query?

> ---
>   drivers/qmimodem/gprs.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/qmimodem/gprs.c b/drivers/qmimodem/gprs.c
> index 27060f9f..49259234 100644
> --- a/drivers/qmimodem/gprs.c
> +++ b/drivers/qmimodem/gprs.c
> @@ -418,7 +418,7 @@ static int qmi_gprs_probev(struct ofono_gprs *gprs,
>   		uint8_t family;
>   	} __attribute((packed)) p = {
>   		.type = QMI_WDS_PROFILE_TYPE_3GPP,
> -		.family = QMI_WDS_PROFILE_FAMILY_EMBEDDED,
> +		.family = QMI_WDS_PROFILE_FAMILY_TETHERED,
>   	};
>   	struct qmi_param *param = qmi_param_new();
>   

Regards,
-Denis
diff mbox series

Patch

diff --git a/drivers/qmimodem/gprs.c b/drivers/qmimodem/gprs.c
index 27060f9f..49259234 100644
--- a/drivers/qmimodem/gprs.c
+++ b/drivers/qmimodem/gprs.c
@@ -418,7 +418,7 @@  static int qmi_gprs_probev(struct ofono_gprs *gprs,
 		uint8_t family;
 	} __attribute((packed)) p = {
 		.type = QMI_WDS_PROFILE_TYPE_3GPP,
-		.family = QMI_WDS_PROFILE_FAMILY_EMBEDDED,
+		.family = QMI_WDS_PROFILE_FAMILY_TETHERED,
 	};
 	struct qmi_param *param = qmi_param_new();