diff mbox series

[v2] qmi: gprs/lte: query for tethered default profile instead of embedded

Message ID 20241211181514.504220-1-ivo.g.dimitrov.75@gmail.com (mailing list archive)
State Accepted
Commit c3335c6e6935e6d7b8810761d7ebf604cd39deb0
Headers show
Series [v2] qmi: gprs/lte: query for tethered default profile instead of embedded | expand

Commit Message

Ivaylo Dimitrov Dec. 11, 2024, 6:15 p.m. UTC
At least the modem in Motorola Droid 4 returns error if embedded 3gpp
profile is queried, however, it does not error if tethered one is used.
qmicli uses tethered when doing --wds-get-default-profile-number=3gpp
---
 drivers/qmimodem/gprs.c | 2 +-
 drivers/qmimodem/lte.c  | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

patchwork-bot+ofono@kernel.org Dec. 11, 2024, 6:30 p.m. UTC | #1
Hello:

This patch was applied to ofono.git (master)
by Denis Kenzior <denkenz@gmail.com>:

On Wed, 11 Dec 2024 20:15:14 +0200 you wrote:
> At least the modem in Motorola Droid 4 returns error if embedded 3gpp
> profile is queried, however, it does not error if tethered one is used.
> qmicli uses tethered when doing --wds-get-default-profile-number=3gpp
> ---
>  drivers/qmimodem/gprs.c | 2 +-
>  drivers/qmimodem/lte.c  | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

Here is the summary with links:
  - [v2] qmi: gprs/lte: query for tethered default profile instead of embedded
    https://git.kernel.org/pub/scm/network/ofono/ofono.git/?id=c3335c6e6935

You are awesome, thank you!
diff mbox series

Patch

diff --git a/drivers/qmimodem/gprs.c b/drivers/qmimodem/gprs.c
index 27060f9f..49259234 100644
--- a/drivers/qmimodem/gprs.c
+++ b/drivers/qmimodem/gprs.c
@@ -418,7 +418,7 @@  static int qmi_gprs_probev(struct ofono_gprs *gprs,
 		uint8_t family;
 	} __attribute((packed)) p = {
 		.type = QMI_WDS_PROFILE_TYPE_3GPP,
-		.family = QMI_WDS_PROFILE_FAMILY_EMBEDDED,
+		.family = QMI_WDS_PROFILE_FAMILY_TETHERED,
 	};
 	struct qmi_param *param = qmi_param_new();
 
diff --git a/drivers/qmimodem/lte.c b/drivers/qmimodem/lte.c
index d2d1048b..0d9f2911 100644
--- a/drivers/qmimodem/lte.c
+++ b/drivers/qmimodem/lte.c
@@ -172,7 +172,7 @@  static int qmimodem_lte_probe(struct ofono_lte *lte,
 		uint8_t family;
 	} __attribute((packed)) p = {
 		.type = QMI_WDS_PROFILE_TYPE_3GPP,
-		.family = QMI_WDS_PROFILE_FAMILY_EMBEDDED,
+		.family = QMI_WDS_PROFILE_FAMILY_TETHERED,
 	};
 	struct lte_data *ldd;