diff mbox

[OPW,kernel] Re: [PATCH v3 1/1] Staging: android: Fix the android logger time format

Message ID 10064039.vA7CXGPPrQ@wuerfel
State New, archived
Headers show

Commit Message

Arnd Bergmann Oct. 30, 2014, 8:13 a.m. UTC
On Wednesday 29 October 2014 15:08:33 'Paul Eastham' via opw-kernel wrote:
> +kernel-team@android.com
> 
> On Wed, Oct 29, 2014 at 3:06 PM, Brian Swetland <swetland@google.com> wrote:
> 
> > Hi Arnd,
> >
> > I'm not doing Android work these days.  Arve or Paul should be able to
> > help or route things to the most appropriate maintainer(s) for logger and
> > its userspace counterparts.
> >
> > Paul -- are we still maintaining an external "android kernel team" alias
> > that would be appropriate for cc'ing on all android-related kernel patches?
> >

Hi Brian,

thanks for your reply. We should probably update the TODO file then,
as below. Arve and Paul, do you want to be listed with your personal
addresses as well, or just the team alias?

	Arnd

8<-------
Subject: [PATCH] staging/android: update contact for Android team

Brian Swetland is no longer the working on this, so let's change
the contact information to the kernel-team email address.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Comments

Rom Lemarchand Oct. 30, 2014, 2:43 p.m. UTC | #1
Hi Arnd,
I think just the team alias is good as people transition in and out of
the team (not saying Paul or Arve are planning on it) and emails are
more likely to go straight to the owner for a particular piece of code
as opposed to going through a 3rd party.

WRT logger, we've been working diligently to try and get rid of it.
The Lollipop Android release uses a logger daemon in lieu of the
current driver but I need to check with the owner whether we're ready
to remove the driver out of the tree altogether.

On Thu, Oct 30, 2014 at 1:13 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> On Wednesday 29 October 2014 15:08:33 'Paul Eastham' via opw-kernel wrote:
>> +kernel-team@android.com
>>
>> On Wed, Oct 29, 2014 at 3:06 PM, Brian Swetland <swetland@google.com> wrote:
>>
>> > Hi Arnd,
>> >
>> > I'm not doing Android work these days.  Arve or Paul should be able to
>> > help or route things to the most appropriate maintainer(s) for logger and
>> > its userspace counterparts.
>> >
>> > Paul -- are we still maintaining an external "android kernel team" alias
>> > that would be appropriate for cc'ing on all android-related kernel patches?
>> >
>
> Hi Brian,
>
> thanks for your reply. We should probably update the TODO file then,
> as below. Arve and Paul, do you want to be listed with your personal
> addresses as well, or just the team alias?
>
>         Arnd
>
> 8<-------
> Subject: [PATCH] staging/android: update contact for Android team
>
> Brian Swetland is no longer the working on this, so let's change
> the contact information to the kernel-team email address.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> diff --git a/drivers/staging/android/TODO b/drivers/staging/android/TODO
> index b15fb0d6b152..aae066553799 100644
> --- a/drivers/staging/android/TODO
> +++ b/drivers/staging/android/TODO
> @@ -7,4 +7,4 @@ TODO:
>         - audit userspace interfaces to make sure they are sane
>
>  Please send patches to Greg Kroah-Hartman <greg@kroah.com> and Cc:
> -Brian Swetland <swetland@google.com>
> +kernel-team@android.com
>
> To unsubscribe from this group and stop receiving emails from it, send an email to kernel-team+unsubscribe@android.com.
Arnd Bergmann Oct. 30, 2014, 2:54 p.m. UTC | #2
On Thursday 30 October 2014 07:43:23 Rom Lemarchand wrote:
> Hi Arnd,
> I think just the team alias is good as people transition in and out of
> the team (not saying Paul or Arve are planning on it) and emails are
> more likely to go straight to the owner for a particular piece of code
> as opposed to going through a 3rd party.

Ok, good. I take that as an Ack on my patch for the TODO file.
 
> WRT logger, we've been working diligently to try and get rid of it.
> The Lollipop Android release uses a logger daemon in lieu of the
> current driver but I need to check with the owner whether we're ready
> to remove the driver out of the tree altogether.

Removing the driver would of course be best, as this gets rid of
a number of problems. It would also make it more likely for Android
machines to survive year 2038. The background here is that 32-bit
kernels are currently not able to run after 2038 because of time_t
overflows, while 64-bit systems are mostly ok. The Android logger
however uses 32-bit timestamps on all machines, so it would be
broken on 64-bit machines as well in its current form.

I think it would be nice to merge Somya's patch anyway, even if
the driver is going to be removed in a few releases. It only
introduces a new user interface that might get used correctly,
while keeping the existing user interfaces (v1 and v2) unchanged.
We are currently doing conversions of all kernel drivers that
suffer from the problem, and fixing it in the kernel would at
least mean that nobody else would have to look at this driver
again, even if you do not introduce the respective user space
portion anywhere.

	Arnd
diff mbox

Patch

diff --git a/drivers/staging/android/TODO b/drivers/staging/android/TODO
index b15fb0d6b152..aae066553799 100644
--- a/drivers/staging/android/TODO
+++ b/drivers/staging/android/TODO
@@ -7,4 +7,4 @@  TODO:
 	- audit userspace interfaces to make sure they are sane
 
 Please send patches to Greg Kroah-Hartman <greg@kroah.com> and Cc:
-Brian Swetland <swetland@google.com>
+kernel-team@android.com