diff mbox

[OPW,kernel] staging: rtl8192u: fix sparse warning, make a function static

Message ID 1382121467-5397-1-git-send-email-teobaluta@gmail.com
State New, archived
Headers show

Commit Message

Teodora Baluta Oct. 18, 2013, 6:37 p.m. UTC
Fix the following sparse warning:
drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c:240:22: warning: symbol 'ieee80211_alloc_txb' was not declared. Should it be static?

Signed-off-by: Teodora Baluta <teobaluta@gmail.com>
---
 drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Waskiewicz Jr, Peter P Oct. 19, 2013, 2:03 a.m. UTC | #1
On Fri, 2013-10-18 at 21:37 +0300, Teodora Baluta wrote:
> Fix the following sparse warning:
> drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c:240:22: warning: symbol 'ieee80211_alloc_txb' was not declared. Should it be static?
> 
> Signed-off-by: Teodora Baluta <teobaluta@gmail.com>

Reviewed-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>

> ---
>  drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c
> index 682659a..157b2d7 100644
> --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c
> +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c
> @@ -237,8 +237,8 @@ void ieee80211_txb_free(struct ieee80211_txb *txb) {
>  	kfree(txb);
>  }
>  
> -struct ieee80211_txb *ieee80211_alloc_txb(int nr_frags, int txb_size,
> -					  gfp_t gfp_mask)
> +static struct ieee80211_txb *ieee80211_alloc_txb(int nr_frags, int txb_size,
> +						 gfp_t gfp_mask)
>  {
>  	struct ieee80211_txb *txb;
>  	int i;
> -- 
> 1.7.10.4
>
Josh Triplett Oct. 19, 2013, 3:25 a.m. UTC | #2
On Fri, Oct 18, 2013 at 09:37:47PM +0300, Teodora Baluta wrote:
> Fix the following sparse warning:
> drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c:240:22: warning: symbol 'ieee80211_alloc_txb' was not declared. Should it be static?
> 
> Signed-off-by: Teodora Baluta <teobaluta@gmail.com>

Reviewed-by: Josh Triplett <josh@joshtriplett.org>

> ---
>  drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c
> index 682659a..157b2d7 100644
> --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c
> +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c
> @@ -237,8 +237,8 @@ void ieee80211_txb_free(struct ieee80211_txb *txb) {
>  	kfree(txb);
>  }
>  
> -struct ieee80211_txb *ieee80211_alloc_txb(int nr_frags, int txb_size,
> -					  gfp_t gfp_mask)
> +static struct ieee80211_txb *ieee80211_alloc_txb(int nr_frags, int txb_size,
> +						 gfp_t gfp_mask)
>  {
>  	struct ieee80211_txb *txb;
>  	int i;
> -- 
> 1.7.10.4
> 
> -- 
> You received this message because you are subscribed to the Google Groups "opw-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to opw-kernel+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
gregkh@linuxfoundation.org Oct. 19, 2013, 12:25 p.m. UTC | #3
On Fri, Oct 18, 2013 at 09:37:47PM +0300, Teodora Baluta wrote:
> Fix the following sparse warning:
> drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c:240:22: warning: symbol 'ieee80211_alloc_txb' was not declared. Should it be static?
> 
> Signed-off-by: Teodora Baluta <teobaluta@gmail.com>

This patch doesn't apply to my tree at all, are we out of sync?  Care to
refresh it against my latest staging-next branch of my staging.git tree
and resend it?

thanks,

greg k-h
gregkh@linuxfoundation.org Oct. 19, 2013, 12:28 p.m. UTC | #4
On Sat, Oct 19, 2013 at 05:25:02AM -0700, Greg KH wrote:
> On Fri, Oct 18, 2013 at 09:37:47PM +0300, Teodora Baluta wrote:
> > Fix the following sparse warning:
> > drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c:240:22: warning: symbol 'ieee80211_alloc_txb' was not declared. Should it be static?
> > 
> > Signed-off-by: Teodora Baluta <teobaluta@gmail.com>
> 
> This patch doesn't apply to my tree at all, are we out of sync?  Care to
> refresh it against my latest staging-next branch of my staging.git tree
> and resend it?

Nevermind, it's too early, I was looking at the wrong tree on my end.
This worked fine, and is now applied, sorry for the noise.

greg k-h
diff mbox

Patch

diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c
index 682659a..157b2d7 100644
--- a/drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c
+++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c
@@ -237,8 +237,8 @@  void ieee80211_txb_free(struct ieee80211_txb *txb) {
 	kfree(txb);
 }
 
-struct ieee80211_txb *ieee80211_alloc_txb(int nr_frags, int txb_size,
-					  gfp_t gfp_mask)
+static struct ieee80211_txb *ieee80211_alloc_txb(int nr_frags, int txb_size,
+						 gfp_t gfp_mask)
 {
 	struct ieee80211_txb *txb;
 	int i;