diff mbox

[OPW,kernel,v2,12/13] staging: rtl8187se: use netdev_info instead of printk

Message ID 1382398644-511-13-git-send-email-teobaluta@gmail.com
State New, archived
Headers show

Commit Message

Teodora Baluta Oct. 21, 2013, 11:37 p.m. UTC
WARNING: Prefer netdev_info(netdev, ... then dev_info(dev, ... then
pr_info(...  to printk(KERN_INFO

Signed-off-by: Teodora Baluta <teobaluta@gmail.com>

---
Changes since v1:
* delete prefix that prints the dev name
---
 drivers/staging/rtl8187se/ieee80211/ieee80211_tx.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Josh Triplett Oct. 21, 2013, 11:51 p.m. UTC | #1
On Tue, Oct 22, 2013 at 02:37:23AM +0300, Teodora Baluta wrote:
> WARNING: Prefer netdev_info(netdev, ... then dev_info(dev, ... then
> pr_info(...  to printk(KERN_INFO
> 
> Signed-off-by: Teodora Baluta <teobaluta@gmail.com>

Reviewed-by: Josh Triplett <josh@joshtriplett.org>

> ---
> Changes since v1:
> * delete prefix that prints the dev name
> ---
>  drivers/staging/rtl8187se/ieee80211/ieee80211_tx.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rtl8187se/ieee80211/ieee80211_tx.c b/drivers/staging/rtl8187se/ieee80211/ieee80211_tx.c
> index 45e9103..ba32df9 100644
> --- a/drivers/staging/rtl8187se/ieee80211/ieee80211_tx.c
> +++ b/drivers/staging/rtl8187se/ieee80211/ieee80211_tx.c
> @@ -224,8 +224,7 @@ int ieee80211_encrypt_fragment(
>  
>  	atomic_dec(&crypt->refcnt);
>  	if (res < 0) {
> -		printk(KERN_INFO "%s: Encryption failed: len=%d.\n",
> -		       ieee->dev->name, frag->len);
> +		netdev_info(ieee->dev, "Encryption failed: len=%d.\n", frag->len);
>  		ieee->ieee_stats.tx_discards++;
>  		return -1;
>  	}
> -- 
> 1.7.10.4
> 
> -- 
> You received this message because you are subscribed to the Google Groups "opw-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to opw-kernel+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
diff mbox

Patch

diff --git a/drivers/staging/rtl8187se/ieee80211/ieee80211_tx.c b/drivers/staging/rtl8187se/ieee80211/ieee80211_tx.c
index 45e9103..ba32df9 100644
--- a/drivers/staging/rtl8187se/ieee80211/ieee80211_tx.c
+++ b/drivers/staging/rtl8187se/ieee80211/ieee80211_tx.c
@@ -224,8 +224,7 @@  int ieee80211_encrypt_fragment(
 
 	atomic_dec(&crypt->refcnt);
 	if (res < 0) {
-		printk(KERN_INFO "%s: Encryption failed: len=%d.\n",
-		       ieee->dev->name, frag->len);
+		netdev_info(ieee->dev, "Encryption failed: len=%d.\n", frag->len);
 		ieee->ieee_stats.tx_discards++;
 		return -1;
 	}