diff mbox

[OPW,kernel] Staging: xgifb: fix braces {} are not necessary for any arm of this statement

Message ID 1382444296-4177-1-git-send-email-ebru.akagunduz@gmail.com
State New, archived
Headers show

Commit Message

Ebru Akagündüz Oct. 22, 2013, 12:18 p.m. UTC
Fix checkpatch.pl issues with braces {} are not necessary
for any arm of this statement in vb_setmode.c

Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com>
---
 drivers/staging/xgifb/vb_setmode.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

Comments

Lisa Nguyen Oct. 23, 2013, 6:39 a.m. UTC | #1
On Tue, Oct 22, 2013 at 5:18 AM, Ebru Akagunduz <ebru.akagunduz@gmail.com>wrote:

> Fix checkpatch.pl issues with braces {} are not necessary
> for any arm of this statement in vb_setmode.c
>
> Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com>
>

Reviewed-by: Lisa Nguyen <lisa@xenapiadmin.com>


> ---
>  drivers/staging/xgifb/vb_setmode.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/xgifb/vb_setmode.c
> b/drivers/staging/xgifb/vb_setmode.c
> index eed58f9..400c726 100644
> --- a/drivers/staging/xgifb/vb_setmode.c
> +++ b/drivers/staging/xgifb/vb_setmode.c
> @@ -845,11 +845,10 @@ static unsigned short XGI_GetVCLK2Ptr(unsigned short
> ModeIdIndex,
>                         VCLKIndex = TVCLKBASE_315_25 + HiTVVCLK;
>
>                 if (pVBInfo->SetFlag & TVSimuMode) {
> -                       if (modeflag & Charx8Dot) {
> +                       if (modeflag & Charx8Dot)
>                                 VCLKIndex = TVCLKBASE_315_25 +
> HiTVSimuVCLK;
> -                       } else {
> +                       else
>                                 VCLKIndex = TVCLKBASE_315_25 +
> HiTVTextVCLK;
> -                       }
>                 }
>
>                 /* 301lv */
> --
> 1.8.1.2
>
> --
> You received this message because you are subscribed to the Google Groups
> "opw-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to opw-kernel+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>
Lisa Nguyen Oct. 23, 2013, 8:49 a.m. UTC | #2
On Tue, Oct 22, 2013 at 11:39 PM, Lisa Nguyen <calculuschick@gmail.com> wrote:
> On Tue, Oct 22, 2013 at 5:18 AM, Ebru Akagunduz <ebru.akagunduz@gmail.com>
> wrote:
>>
>> Fix checkpatch.pl issues with braces {} are not necessary
>> for any arm of this statement in vb_setmode.c
>>
>> Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com>

Whoops, accidentally used my personal email address and forgot to make
sure I respond back in plain text.

(It's what I get for reviewing so late at night in my timezone...)

Reviewed-by: Lisa Nguyen <lisa@xenapiadmin.com>

>>
>> ---
>>  drivers/staging/xgifb/vb_setmode.c | 5 ++---
>>  1 file changed, 2 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/staging/xgifb/vb_setmode.c
>> b/drivers/staging/xgifb/vb_setmode.c
>> index eed58f9..400c726 100644
>> --- a/drivers/staging/xgifb/vb_setmode.c
>> +++ b/drivers/staging/xgifb/vb_setmode.c
>> @@ -845,11 +845,10 @@ static unsigned short XGI_GetVCLK2Ptr(unsigned short
>> ModeIdIndex,
>>                         VCLKIndex = TVCLKBASE_315_25 + HiTVVCLK;
>>
>>                 if (pVBInfo->SetFlag & TVSimuMode) {
>> -                       if (modeflag & Charx8Dot) {
>> +                       if (modeflag & Charx8Dot)
>>                                 VCLKIndex = TVCLKBASE_315_25 +
>> HiTVSimuVCLK;
>> -                       } else {
>> +                       else
>>                                 VCLKIndex = TVCLKBASE_315_25 +
>> HiTVTextVCLK;
>> -                       }
>>                 }
>>
>>                 /* 301lv */
>> --
>> 1.8.1.2
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "opw-kernel" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to opw-kernel+unsubscribe@googlegroups.com.
>> For more options, visit https://groups.google.com/groups/opt_out.
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "opw-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to opw-kernel+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
diff mbox

Patch

diff --git a/drivers/staging/xgifb/vb_setmode.c b/drivers/staging/xgifb/vb_setmode.c
index eed58f9..400c726 100644
--- a/drivers/staging/xgifb/vb_setmode.c
+++ b/drivers/staging/xgifb/vb_setmode.c
@@ -845,11 +845,10 @@  static unsigned short XGI_GetVCLK2Ptr(unsigned short ModeIdIndex,
 			VCLKIndex = TVCLKBASE_315_25 + HiTVVCLK;
 
 		if (pVBInfo->SetFlag & TVSimuMode) {
-			if (modeflag & Charx8Dot) {
+			if (modeflag & Charx8Dot)
 				VCLKIndex = TVCLKBASE_315_25 + HiTVSimuVCLK;
-			} else {
+			else
 				VCLKIndex = TVCLKBASE_315_25 + HiTVTextVCLK;
-			}
 		}
 
 		/* 301lv */