diff mbox

[OPW,kernel,3/7] staging: r8188eu: do not use comparisons on bool tests

Message ID 1382644886-3529-1-git-send-email-valentina.manea.m@gmail.com
State New, archived
Headers show

Commit Message

Valentina Manea Oct. 24, 2013, 8:01 p.m. UTC
This patch fixes coccinelle errors regarding comparisons
used in bool tests.

Signed-off-by: Valentina Manea <valentina.manea.m@gmail.com>
---
 drivers/staging/rtl8188eu/core/rtw_pwrctrl.c   | 2 +-
 drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)

Comments

Rusty Russell Oct. 25, 2013, 12:34 a.m. UTC | #1
Valentina Manea <valentina.manea.m@gmail.com> writes:

> This patch fixes coccinelle errors regarding comparisons
> used in bool tests.
>
> Signed-off-by: Valentina Manea <valentina.manea.m@gmail.com>

Reviewed-by: Rusty Russell <rusty@rustcorp.com.au>

Cheers,
Rusty.

> ---
>  drivers/staging/rtl8188eu/core/rtw_pwrctrl.c   | 2 +-
>  drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c | 6 +++---
>  2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/rtl8188eu/core/rtw_pwrctrl.c b/drivers/staging/rtl8188eu/core/rtw_pwrctrl.c
> index 58a1661..b45461f 100644
> --- a/drivers/staging/rtl8188eu/core/rtw_pwrctrl.c
> +++ b/drivers/staging/rtl8188eu/core/rtw_pwrctrl.c
> @@ -193,7 +193,7 @@ void rtw_ps_processor(struct adapter *padapter)
>  	if (pwrpriv->ips_mode_req == IPS_NONE)
>  		goto exit;
>  
> -	if (rtw_pwr_unassociated_idle(padapter) == false)
> +	if (!rtw_pwr_unassociated_idle(padapter))
>  		goto exit;
>  
>  	if ((pwrpriv->rf_pwrstate == rf_on) && ((pwrpriv->pwr_state_check_cnts%4) == 0)) {
> diff --git a/drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c b/drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c
> index e4f20da..db61d52 100644
> --- a/drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c
> +++ b/drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c
> @@ -819,7 +819,7 @@ void _PHY_SaveADDARegisters(struct adapter *adapt, u32 *ADDAReg, u32 *ADDABackup
>  	struct hal_data_8188e	*pHalData = GET_HAL_DATA(adapt);
>  	struct odm_dm_struct *dm_odm = &pHalData->odmpriv;
>  
> -	if (ODM_CheckPowerStatus(adapt) == false)
> +	if (!ODM_CheckPowerStatus(adapt))
>  		return;
>  
>  	ODM_RT_TRACE(dm_odm, ODM_COMP_CALIBRATION, ODM_DBG_LOUD, ("Save ADDA parameters.\n"));
> @@ -888,7 +888,7 @@ _PHY_PathADDAOn(
>  	ODM_RT_TRACE(dm_odm, ODM_COMP_CALIBRATION, ODM_DBG_LOUD, ("ADDA ON.\n"));
>  
>  	pathOn = isPathAOn ? 0x04db25a4 : 0x0b1b25a4;
> -	if (false == is2t) {
> +	if (!is2t) {
>  		pathOn = 0x0bdb25a0;
>  		ODM_SetBBReg(dm_odm, ADDAReg[0], bMaskDWord, 0x0b1b25a0);
>  	} else {
> @@ -1697,7 +1697,7 @@ void PHY_IQCalibrate_8188E(struct adapter *adapt, bool recovery)
>  	bool is2t;
>  
>  	is2t = (dm_odm->RFType == ODM_2T2R) ? true : false;
> -	if (ODM_CheckPowerStatus(adapt) == false)
> +	if (!ODM_CheckPowerStatus(adapt))
>  		return;
>  
>  	if (!(dm_odm->SupportAbility & ODM_RF_CALIBRATION))
> -- 
> 1.8.1.2
>
> -- 
> You received this message because you are subscribed to the Google Groups "opw-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to opw-kernel+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
diff mbox

Patch

diff --git a/drivers/staging/rtl8188eu/core/rtw_pwrctrl.c b/drivers/staging/rtl8188eu/core/rtw_pwrctrl.c
index 58a1661..b45461f 100644
--- a/drivers/staging/rtl8188eu/core/rtw_pwrctrl.c
+++ b/drivers/staging/rtl8188eu/core/rtw_pwrctrl.c
@@ -193,7 +193,7 @@  void rtw_ps_processor(struct adapter *padapter)
 	if (pwrpriv->ips_mode_req == IPS_NONE)
 		goto exit;
 
-	if (rtw_pwr_unassociated_idle(padapter) == false)
+	if (!rtw_pwr_unassociated_idle(padapter))
 		goto exit;
 
 	if ((pwrpriv->rf_pwrstate == rf_on) && ((pwrpriv->pwr_state_check_cnts%4) == 0)) {
diff --git a/drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c b/drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c
index e4f20da..db61d52 100644
--- a/drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c
+++ b/drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c
@@ -819,7 +819,7 @@  void _PHY_SaveADDARegisters(struct adapter *adapt, u32 *ADDAReg, u32 *ADDABackup
 	struct hal_data_8188e	*pHalData = GET_HAL_DATA(adapt);
 	struct odm_dm_struct *dm_odm = &pHalData->odmpriv;
 
-	if (ODM_CheckPowerStatus(adapt) == false)
+	if (!ODM_CheckPowerStatus(adapt))
 		return;
 
 	ODM_RT_TRACE(dm_odm, ODM_COMP_CALIBRATION, ODM_DBG_LOUD, ("Save ADDA parameters.\n"));
@@ -888,7 +888,7 @@  _PHY_PathADDAOn(
 	ODM_RT_TRACE(dm_odm, ODM_COMP_CALIBRATION, ODM_DBG_LOUD, ("ADDA ON.\n"));
 
 	pathOn = isPathAOn ? 0x04db25a4 : 0x0b1b25a4;
-	if (false == is2t) {
+	if (!is2t) {
 		pathOn = 0x0bdb25a0;
 		ODM_SetBBReg(dm_odm, ADDAReg[0], bMaskDWord, 0x0b1b25a0);
 	} else {
@@ -1697,7 +1697,7 @@  void PHY_IQCalibrate_8188E(struct adapter *adapt, bool recovery)
 	bool is2t;
 
 	is2t = (dm_odm->RFType == ODM_2T2R) ? true : false;
-	if (ODM_CheckPowerStatus(adapt) == false)
+	if (!ODM_CheckPowerStatus(adapt))
 		return;
 
 	if (!(dm_odm->SupportAbility & ODM_RF_CALIBRATION))