diff mbox

[OPW,kernel,2/6] staging: rtl8187se: fix assignment of bool to 0/1

Message ID 1382645851-928-3-git-send-email-teobaluta@gmail.com
State New, archived
Headers show

Commit Message

Teodora Baluta Oct. 24, 2013, 8:17 p.m. UTC
This patch fixes the following coccinelle warnings:

drivers/staging/rtl8187se/r8180_core.c:2433:1-20: WARNING: Assignment of bool to 0/1
drivers/staging/rtl8187se/r8180_core.c:2275:3-34: WARNING: Assignment of bool to 0/1

Signed-off-by: Teodora Baluta <teobaluta@gmail.com>
---
 drivers/staging/rtl8187se/r8180_core.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Rusty Russell Oct. 25, 2013, 12:58 a.m. UTC | #1
Teodora Baluta <teobaluta@gmail.com> writes:
> This patch fixes the following coccinelle warnings:
>
> drivers/staging/rtl8187se/r8180_core.c:2433:1-20: WARNING: Assignment of bool to 0/1
> drivers/staging/rtl8187se/r8180_core.c:2275:3-34: WARNING: Assignment of bool to 0/1
>
> Signed-off-by: Teodora Baluta <teobaluta@gmail.com>

Reviewed-by: Rusty Russell <rusty@rustcorp.com.au>

Cheers,
Rusty.

> ---
>  drivers/staging/rtl8187se/r8180_core.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8187se/r8180_core.c b/drivers/staging/rtl8187se/r8180_core.c
> index 55dfd5e..eb98222 100644
> --- a/drivers/staging/rtl8187se/r8180_core.c
> +++ b/drivers/staging/rtl8187se/r8180_core.c
> @@ -2272,7 +2272,7 @@ static void rtl8180_set_channel_map(u8 channel_plan, struct ieee80211_device *ie
>  		}
>  	case COUNTRY_CODE_GLOBAL_DOMAIN:
>  		{
> -			GET_DOT11D_INFO(ieee)->bEnabled = 0;
> +			GET_DOT11D_INFO(ieee)->bEnabled = false;
>  			Dot11d_Reset(ieee);
>  			ieee->bGlobalDomain = true;
>  			break;
> @@ -2430,7 +2430,7 @@ short rtl8180_init(struct net_device *dev)
>  	init_timer(&priv->SwAntennaDiversityTimer);
>  	priv->SwAntennaDiversityTimer.data = (unsigned long)dev;
>  	priv->SwAntennaDiversityTimer.function = (void *)SwAntennaDiversityTimerCallback;
> -	priv->bDigMechanism = 1;
> +	priv->bDigMechanism = true;
>  	priv->InitialGain = 6;
>  	priv->bXtalCalibration = false;
>  	priv->XtalCal_Xin = 0;
> -- 
> 1.7.10.4
>
> -- 
> You received this message because you are subscribed to the Google Groups "opw-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to opw-kernel+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
diff mbox

Patch

diff --git a/drivers/staging/rtl8187se/r8180_core.c b/drivers/staging/rtl8187se/r8180_core.c
index 55dfd5e..eb98222 100644
--- a/drivers/staging/rtl8187se/r8180_core.c
+++ b/drivers/staging/rtl8187se/r8180_core.c
@@ -2272,7 +2272,7 @@  static void rtl8180_set_channel_map(u8 channel_plan, struct ieee80211_device *ie
 		}
 	case COUNTRY_CODE_GLOBAL_DOMAIN:
 		{
-			GET_DOT11D_INFO(ieee)->bEnabled = 0;
+			GET_DOT11D_INFO(ieee)->bEnabled = false;
 			Dot11d_Reset(ieee);
 			ieee->bGlobalDomain = true;
 			break;
@@ -2430,7 +2430,7 @@  short rtl8180_init(struct net_device *dev)
 	init_timer(&priv->SwAntennaDiversityTimer);
 	priv->SwAntennaDiversityTimer.data = (unsigned long)dev;
 	priv->SwAntennaDiversityTimer.function = (void *)SwAntennaDiversityTimerCallback;
-	priv->bDigMechanism = 1;
+	priv->bDigMechanism = true;
 	priv->InitialGain = 6;
 	priv->bXtalCalibration = false;
 	priv->XtalCal_Xin = 0;