diff mbox

[OPW,kernel,6/6] staging: rtl8187se: delete duplicated argument to |

Message ID 1382645851-928-7-git-send-email-teobaluta@gmail.com
State New, archived
Headers show

Commit Message

Teodora Baluta Oct. 24, 2013, 8:17 p.m. UTC
This patch fixes the following coccinelle issue for a mask calculation:

drivers/staging/rtl8187se/r8180_core.c:2552:44-54: duplicated argument to & or |

Signed-off-by: Teodora Baluta <teobaluta@gmail.com>
---
 drivers/staging/rtl8187se/r8180_core.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Rusty Russell Oct. 25, 2013, 1:01 a.m. UTC | #1
Teodora Baluta <teobaluta@gmail.com> writes:
> This patch fixes the following coccinelle issue for a mask calculation:
>
> drivers/staging/rtl8187se/r8180_core.c:2552:44-54: duplicated argument to & or |
>
> Signed-off-by: Teodora Baluta <teobaluta@gmail.com>

Reviewed-by: Rusty Russell <rusty@rustcorp.com.au>

Cheers,
Rusty.

> ---
>  drivers/staging/rtl8187se/r8180_core.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8187se/r8180_core.c b/drivers/staging/rtl8187se/r8180_core.c
> index 8d767f3..76a6738 100644
> --- a/drivers/staging/rtl8187se/r8180_core.c
> +++ b/drivers/staging/rtl8187se/r8180_core.c
> @@ -2549,7 +2549,7 @@ short rtl8180_init(struct net_device *dev)
>  				(priv->EarlyRxThreshold == 7 ?
>  					 RCR_ONLYERLPKT : 0);
>  
> -	priv->IntrMask		= IMR_TMGDOK | IMR_TBDER | IMR_THPDER |
> +	priv->IntrMask		= IMR_TMGDOK | IMR_TBDER |
>  				  IMR_THPDER | IMR_THPDOK |
>  				  IMR_TVODER | IMR_TVODOK |
>  				  IMR_TVIDER | IMR_TVIDOK |
> -- 
> 1.7.10.4
>
> -- 
> You received this message because you are subscribed to the Google Groups "opw-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to opw-kernel+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
diff mbox

Patch

diff --git a/drivers/staging/rtl8187se/r8180_core.c b/drivers/staging/rtl8187se/r8180_core.c
index 8d767f3..76a6738 100644
--- a/drivers/staging/rtl8187se/r8180_core.c
+++ b/drivers/staging/rtl8187se/r8180_core.c
@@ -2549,7 +2549,7 @@  short rtl8180_init(struct net_device *dev)
 				(priv->EarlyRxThreshold == 7 ?
 					 RCR_ONLYERLPKT : 0);
 
-	priv->IntrMask		= IMR_TMGDOK | IMR_TBDER | IMR_THPDER |
+	priv->IntrMask		= IMR_TMGDOK | IMR_TBDER |
 				  IMR_THPDER | IMR_THPDOK |
 				  IMR_TVODER | IMR_TVODOK |
 				  IMR_TVIDER | IMR_TVIDOK |