diff mbox

[OPW,kernel] Staging: winbond: Fix Sparse Warning for Static Declarations in phy_calibration.c

Message ID 1382655011-3050-1-git-send-email-ebru.akagunduz@gmail.com
State New, archived
Headers show

Commit Message

Ebru Akagündüz Oct. 24, 2013, 10:50 p.m. UTC
This patch fixes the Sparse Warning "symbol was
not declared. Should it be static?" in phy_calibration.c

Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com>
---
 drivers/staging/winbond/phy_calibration.c | 42 +++++++++++++++----------------
 1 file changed, 21 insertions(+), 21 deletions(-)

Comments

Greg KH Oct. 27, 2013, 2:08 p.m. UTC | #1
On Fri, Oct 25, 2013 at 01:50:11AM +0300, Ebru Akagunduz wrote:
> This patch fixes the Sparse Warning "symbol was
> not declared. Should it be static?" in phy_calibration.c
> 
> Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com>

Same here, lots of new warnings, please fix that up and resend.

thanks,

greg k-h
diff mbox

Patch

diff --git a/drivers/staging/winbond/phy_calibration.c b/drivers/staging/winbond/phy_calibration.c
index d970660..abeb4fe 100644
--- a/drivers/staging/winbond/phy_calibration.c
+++ b/drivers/staging/winbond/phy_calibration.c
@@ -44,7 +44,7 @@  static const s32 Angles[] = {
 
 /****************** FUNCTION DEFINITION SECTION *****************************/
 
-s32 _s13_to_s32(u32 data)
+static s32 _s13_to_s32(u32 data)
 {
 	u32     val;
 
@@ -56,7 +56,7 @@  s32 _s13_to_s32(u32 data)
 	return (s32) val;
 }
 
-u32 _s32_to_s13(s32 data)
+static u32 _s32_to_s13(s32 data)
 {
 	u32     val;
 
@@ -71,7 +71,7 @@  u32 _s32_to_s13(s32 data)
 }
 
 /****************************************************************************/
-s32 _s4_to_s32(u32 data)
+static s32 _s4_to_s32(u32 data)
 {
 	s32     val;
 
@@ -83,7 +83,7 @@  s32 _s4_to_s32(u32 data)
 	return val;
 }
 
-u32 _s32_to_s4(s32 data)
+static u32 _s32_to_s4(s32 data)
 {
 	u32     val;
 
@@ -98,7 +98,7 @@  u32 _s32_to_s4(s32 data)
 }
 
 /****************************************************************************/
-s32 _s5_to_s32(u32 data)
+static s32 _s5_to_s32(u32 data)
 {
 	s32     val;
 
@@ -110,7 +110,7 @@  s32 _s5_to_s32(u32 data)
 	return val;
 }
 
-u32 _s32_to_s5(s32 data)
+static u32 _s32_to_s5(s32 data)
 {
 	u32     val;
 
@@ -125,7 +125,7 @@  u32 _s32_to_s5(s32 data)
 }
 
 /****************************************************************************/
-s32 _s6_to_s32(u32 data)
+static s32 _s6_to_s32(u32 data)
 {
 	s32     val;
 
@@ -137,7 +137,7 @@  s32 _s6_to_s32(u32 data)
 	return val;
 }
 
-u32 _s32_to_s6(s32 data)
+static u32 _s32_to_s6(s32 data)
 {
 	u32     val;
 
@@ -152,7 +152,7 @@  u32 _s32_to_s6(s32 data)
 }
 
 /****************************************************************************/
-s32 _s9_to_s32(u32 data)
+static s32 _s9_to_s32(u32 data)
 {
 	s32     val;
 
@@ -164,7 +164,7 @@  s32 _s9_to_s32(u32 data)
 	return val;
 }
 
-u32 _s32_to_s9(s32 data)
+static u32 _s32_to_s9(s32 data)
 {
 	u32     val;
 
@@ -179,7 +179,7 @@  u32 _s32_to_s9(s32 data)
 }
 
 /****************************************************************************/
-s32 _floor(s32 n)
+static s32 _floor(s32 n)
 {
 	if (n > 0)
 		n += 5;
@@ -195,7 +195,7 @@  s32 _floor(s32 n)
  * sqsum is the input and the output is sq_rt;
  * The maximum of sqsum = 2^27 -1;
  */
-u32 _sqrt(u32 sqsum)
+static u32 _sqrt(u32 sqsum)
 {
 	u32     sq_rt;
 
@@ -263,7 +263,7 @@  u32 _sqrt(u32 sqsum)
 }
 
 /****************************************************************************/
-void _sin_cos(s32 angle, s32 *sin, s32 *cos)
+static void _sin_cos(s32 angle, s32 *sin, s32 *cos)
 {
 	s32 X, Y, TargetAngle, CurrAngle;
 	unsigned    Step;
@@ -320,7 +320,7 @@  static unsigned char hal_set_dxx_reg(struct hw_data *pHwData, u16 number,
 #define hw_set_dxx_reg(_A, _B, _C) hal_set_dxx_reg(_A, _B, (u32)_C)
 
 
-void _reset_rx_cal(struct hw_data *phw_data)
+static void _reset_rx_cal(struct hw_data *phw_data)
 {
 	u32     val;
 
@@ -340,7 +340,7 @@  void _reset_rx_cal(struct hw_data *phw_data)
 
 
 /**********************************************/
-void _rxadc_dc_offset_cancellation_winbond(struct hw_data *phw_data, u32 frequency)
+static void _rxadc_dc_offset_cancellation_winbond(struct hw_data *phw_data, u32 frequency)
 {
 	u32     reg_agc_ctrl3;
 	u32     reg_a_acq_ctrl;
@@ -436,7 +436,7 @@  void _rxadc_dc_offset_cancellation_winbond(struct hw_data *phw_data, u32 frequen
 }
 
 /****************************************************************/
-void _txidac_dc_offset_cancellation_winbond(struct hw_data *phw_data)
+static void _txidac_dc_offset_cancellation_winbond(struct hw_data *phw_data)
 {
 	u32     reg_agc_ctrl3;
 	u32     reg_mode_ctrl;
@@ -562,7 +562,7 @@  void _txidac_dc_offset_cancellation_winbond(struct hw_data *phw_data)
 }
 
 /*****************************************************/
-void _txqdac_dc_offset_cacellation_winbond(struct hw_data *phw_data)
+static void _txqdac_dc_offset_cacellation_winbond(struct hw_data *phw_data)
 {
 	u32     reg_agc_ctrl3;
 	u32     reg_mode_ctrl;
@@ -678,7 +678,7 @@  void _txqdac_dc_offset_cacellation_winbond(struct hw_data *phw_data)
 }
 
 /* 20060612.1.a 20060718.1 Modify */
-u8 _tx_iq_calibration_loop_winbond(struct hw_data *phw_data,
+static u8 _tx_iq_calibration_loop_winbond(struct hw_data *phw_data,
 						   s32 a_2_threshold,
 						   s32 b_2_threshold)
 {
@@ -962,7 +962,7 @@  u8 _tx_iq_calibration_loop_winbond(struct hw_data *phw_data,
 	return 1;
 }
 
-void _tx_iq_calibration_winbond(struct hw_data *phw_data)
+static void _tx_iq_calibration_winbond(struct hw_data *phw_data)
 {
 	u32     reg_agc_ctrl3;
 #ifdef _DEBUG
@@ -1108,7 +1108,7 @@  void _tx_iq_calibration_winbond(struct hw_data *phw_data)
 }
 
 /*****************************************************/
-u8 _rx_iq_calibration_loop_winbond(struct hw_data *phw_data, u16 factor, u32 frequency)
+static u8 _rx_iq_calibration_loop_winbond(struct hw_data *phw_data, u16 factor, u32 frequency)
 {
 	u32     reg_mode_ctrl;
 	s32     iqcal_tone_i;
@@ -1382,7 +1382,7 @@  u8 _rx_iq_calibration_loop_winbond(struct hw_data *phw_data, u16 factor, u32 fre
 /*************************************************/
 
 /***************************************************************/
-void _rx_iq_calibration_winbond(struct hw_data *phw_data, u32 frequency)
+static void _rx_iq_calibration_winbond(struct hw_data *phw_data, u32 frequency)
 {
 /* figo 20050523 marked this flag for can't compile for release */
 #ifdef _DEBUG