diff mbox

[OPW,kernel,v2,5/6] staging: rtl8187se: replace memcpy with struct assignment

Message ID 1382691619-3668-6-git-send-email-teobaluta@gmail.com
State New, archived
Headers show

Commit Message

Teodora Baluta Oct. 25, 2013, 9 a.m. UTC
This patch fixes the following issue found with coccinelle:

drivers/staging/rtl8187se/ieee80211/ieee80211_rx.c:1437:2-8: Replace memcpy with struct assignment

Signed-off-by: Teodora Baluta <teobaluta@gmail.com>
Reviewed-by: Rusty Russell <rusty@rustcorp.com.au>
---
 drivers/staging/rtl8187se/ieee80211/ieee80211_rx.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Greg KH Oct. 28, 2013, 9:34 p.m. UTC | #1
On Fri, Oct 25, 2013 at 12:00:18PM +0300, Teodora Baluta wrote:
> This patch fixes the following issue found with coccinelle:
> 
> drivers/staging/rtl8187se/ieee80211/ieee80211_rx.c:1437:2-8: Replace memcpy with struct assignment
> 
> Signed-off-by: Teodora Baluta <teobaluta@gmail.com>
> Reviewed-by: Rusty Russell <rusty@rustcorp.com.au>
> ---
>  drivers/staging/rtl8187se/ieee80211/ieee80211_rx.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8187se/ieee80211/ieee80211_rx.c b/drivers/staging/rtl8187se/ieee80211/ieee80211_rx.c
> index 3045790..dbfcec7 100644
> --- a/drivers/staging/rtl8187se/ieee80211/ieee80211_rx.c
> +++ b/drivers/staging/rtl8187se/ieee80211/ieee80211_rx.c
> @@ -1434,7 +1434,7 @@ inline void ieee80211_process_probe_response(
>  				     "PROBE RESPONSE" : "BEACON");
>  #endif
>  
> -		memcpy(target, &network, sizeof(*target));
> +		*target = network;

I'm not comfortable with this change, sorry.

greg k-h
diff mbox

Patch

diff --git a/drivers/staging/rtl8187se/ieee80211/ieee80211_rx.c b/drivers/staging/rtl8187se/ieee80211/ieee80211_rx.c
index 3045790..dbfcec7 100644
--- a/drivers/staging/rtl8187se/ieee80211/ieee80211_rx.c
+++ b/drivers/staging/rtl8187se/ieee80211/ieee80211_rx.c
@@ -1434,7 +1434,7 @@  inline void ieee80211_process_probe_response(
 				     "PROBE RESPONSE" : "BEACON");
 #endif
 
-		memcpy(target, &network, sizeof(*target));
+		*target = network;
 		list_add_tail(&target->list, &ieee->network_list);
 	} else {
 		IEEE80211_DEBUG_SCAN("Updating '%s' (%pM) via %s.\n",