diff mbox

[OPW,kernel,02/11] staging: vt6656: fixed open brace placement related error

Message ID 1384208208-12564-2-git-send-email-nandu.hgowda@gmail.com
State New, archived
Headers show

Commit Message

nandini h Nov. 11, 2013, 10:16 p.m. UTC
fixed the following checkpatch error:
	ERROR: that open brace { should be on the previous line

Signed-off-by: Nandini Hanumanthagowda <nandu.hgowda@gmail.com>
---
 drivers/staging/vt6656/wcmd.c |   12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

Comments

Andrew Grover Nov. 11, 2013, 10:23 p.m. UTC | #1
On Mon, Nov 11, 2013 at 2:16 PM, Nandini Hanumanthagowda <
nandu.hgowda@gmail.com> wrote:

> fixed the following checkpatch error:
>         ERROR: that open brace { should be on the previous line
>
> Signed-off-by: Nandini Hanumanthagowda <nandu.hgowda@gmail.com>
> ---
>  drivers/staging/vt6656/wcmd.c |   12 ++++--------
>  1 file changed, 4 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/staging/vt6656/wcmd.c b/drivers/staging/vt6656/wcmd.c
> index 22d0038..927d963 100644
> --- a/drivers/staging/vt6656/wcmd.c
> +++ b/drivers/staging/vt6656/wcmd.c
> @@ -100,19 +100,16 @@ static void vAdHocBeaconStop(struct vnt_private
> *pDevice)
>       */
>      bStop = false;
>      if ((pMgmt->eCurrMode == WMAC_MODE_IBSS_STA) &&
> -    (pMgmt->eCurrState >= WMAC_STATE_STARTED))
> -    {
> +    (pMgmt->eCurrState >= WMAC_STATE_STARTED)) {
>          if ((pMgmt->uIBSSChannel <=  CB_MAX_CHANNEL_24G) &&
> -             (pMgmt->uScanChannel > CB_MAX_CHANNEL_24G))
> -        {
> +             (pMgmt->uScanChannel > CB_MAX_CHANNEL_24G)) {
>              bStop = true;
>          }
>          if (pMgmt->uIBSSChannel >  CB_MAX_CHANNEL_24G)
>              bStop = true;
>      }
>
> -    if (bStop)
> -    {
> +    if (bStop) {
>          //PMESG(("STOP_BEACON: IBSSChannel = %u, ScanChannel = %u\n",
>          //        pMgmt->uIBSSChannel, pMgmt->uScanChannel));
>          MACvRegBitsOff(pDevice, MAC_REG_TCR, TCR_AUTOBCNTX);
> @@ -144,8 +141,7 @@ static void vAdHocBeaconRestart(struct vnt_private
> *pDevice)
>       *  (2) VT3253 is programmed as automatic Beacon Transmitting
>       */
>      if ((pMgmt->eCurrMode == WMAC_MODE_IBSS_STA) &&
> -    (pMgmt->eCurrState >= WMAC_STATE_STARTED))
> -    {
> +    (pMgmt->eCurrState >= WMAC_STATE_STARTED)) {
>          //PMESG(("RESTART_BEACON\n"));
>          MACvRegBitsOn(pDevice, MAC_REG_TCR, TCR_AUTOBCNTX);
>      }
> --
> 1.7.9.5
>

Reviewed-by: Andy Grover <agrover@redhat.com>
'Greg KH' Nov. 12, 2013, 9:49 a.m. UTC | #2
On Tue, Nov 12, 2013 at 03:46:39AM +0530, Nandini Hanumanthagowda wrote:
> fixed the following checkpatch error:
> 	ERROR: that open brace { should be on the previous line
> 
> Signed-off-by: Nandini Hanumanthagowda <nandu.hgowda@gmail.com>

Because I can't take your first patch, this one doesn't apply, and odds
are, all of the other ones will not either, so I can't take these,
sorry.

Can you redo them please?  I know it will be past the deadline, but I'd
still like to get these fixes into the kernel tree.

thanks,

greg k-h
nandini h Nov. 12, 2013, 5:41 p.m. UTC | #3
On Tuesday, November 12, 2013 3:19:17 PM UTC+5:30, Greg Kroah-Hartman wrote:
>
> On Tue, Nov 12, 2013 at 03:46:39AM +0530, Nandini Hanumanthagowda wrote: 
> >> fixed the following checkpatch error: 
> >>         ERROR: that open brace { should be on the previous line 
> >> 
> >> Signed-off-by: Nandini Hanumanthagowda <nandu....@gmail.com<javascript:>> 
>
>
> >Because I can't take your first patch, this one doesn't apply, and odds 
> >are, all of the other ones will not either, so I can't take these, 
> >sorry. 
>
> >Can you redo them please?  I know it will be past the deadline, but I'd 
> >still like to get these fixes into the kernel tree. 
>
> >thanks, 
>
> >greg k-h 
>

Hi greg,
Sorry, it was my mistake. I overlooked those whitespace errors. Next time I 
will be more careful.
I fixed those whitespace errors added and resent the refreshed patch series 
"PATCH v2".

Thanks and regards,
Nandini
diff mbox

Patch

diff --git a/drivers/staging/vt6656/wcmd.c b/drivers/staging/vt6656/wcmd.c
index 22d0038..927d963 100644
--- a/drivers/staging/vt6656/wcmd.c
+++ b/drivers/staging/vt6656/wcmd.c
@@ -100,19 +100,16 @@  static void vAdHocBeaconStop(struct vnt_private *pDevice)
      */
     bStop = false;
     if ((pMgmt->eCurrMode == WMAC_MODE_IBSS_STA) &&
-    (pMgmt->eCurrState >= WMAC_STATE_STARTED))
-    {
+    (pMgmt->eCurrState >= WMAC_STATE_STARTED)) {
         if ((pMgmt->uIBSSChannel <=  CB_MAX_CHANNEL_24G) &&
-             (pMgmt->uScanChannel > CB_MAX_CHANNEL_24G))
-        {
+             (pMgmt->uScanChannel > CB_MAX_CHANNEL_24G)) {
             bStop = true;
         }
         if (pMgmt->uIBSSChannel >  CB_MAX_CHANNEL_24G)
             bStop = true;
     }
 
-    if (bStop)
-    {
+    if (bStop) {
         //PMESG(("STOP_BEACON: IBSSChannel = %u, ScanChannel = %u\n",
         //        pMgmt->uIBSSChannel, pMgmt->uScanChannel));
         MACvRegBitsOff(pDevice, MAC_REG_TCR, TCR_AUTOBCNTX);
@@ -144,8 +141,7 @@  static void vAdHocBeaconRestart(struct vnt_private *pDevice)
      *  (2) VT3253 is programmed as automatic Beacon Transmitting
      */
     if ((pMgmt->eCurrMode == WMAC_MODE_IBSS_STA) &&
-    (pMgmt->eCurrState >= WMAC_STATE_STARTED))
-    {
+    (pMgmt->eCurrState >= WMAC_STATE_STARTED)) {
         //PMESG(("RESTART_BEACON\n"));
         MACvRegBitsOn(pDevice, MAC_REG_TCR, TCR_AUTOBCNTX);
     }