diff mbox

[OPW,kernel] staging:vt6655/wroute.c: Fix checkpatch error

Message ID 1410689074-4997-1-git-send-email-lavinia.tachee@gmail.com
State New, archived
Headers show

Commit Message

tachelavinia Sept. 14, 2014, 10:04 a.m. UTC
This fixes the checkpatch error:
ERROR: do not use C99 // comments

Signed-off-by: tachelavinia <lavinia.tachee@gmail.com>
---
 drivers/staging/vt6655/wroute.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Sarah Sharp Sept. 15, 2014, 2:58 p.m. UTC | #1
Greetings,

Thanks for sending your first patch!  I see a couple things that need to
be improved here, so please try again with a revised patch.

Using "Fix checkpatch error" in your subject line is too generic.  We
need to tell at a glance at the patch subject line exactly what
checkpatch error you're fixing.  Please put which checkpatch error you
are fixing in your subject line.

E.g. "staging:vt6655/wroute.c: Remove C99 // comments"

More comments below.

On Sun, Sep 14, 2014 at 01:04:34PM +0300, tachelavinia wrote:
> This fixes the checkpatch error:
> ERROR: do not use C99 // comments
> 
> Signed-off-by: tachelavinia <lavinia.tachee@gmail.com>

Is tachelavinia your full, legal name?  If not, you need to edit your
.gitconfig to set user.name to your legal name, and update the
authorship information in your patch in both the author name and the
signed-off-by line.  If this commit if your HEAD commit (top commit),
run:

git commit --amend --author="Your Name" -s

And remove the second, incorrect Signed-off-by line.

If you have several commits under that name, you'll need to learn how to
use `git rebase -i`, edit each commit, and amend the commit to have the
right authorship information.

If you need any help amending your commits or sending your revised
patch, please ask on IRC.

Thanks,
Sarah Sharp

> ---
>  drivers/staging/vt6655/wroute.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/vt6655/wroute.c b/drivers/staging/vt6655/wroute.c
> index d1171fa..6606a1c 100644
> --- a/drivers/staging/vt6655/wroute.c
> +++ b/drivers/staging/vt6655/wroute.c
> @@ -94,7 +94,7 @@ bool ROUTEbRelay(struct vnt_private *pDevice, unsigned char *pbySkbData,
>  	if (pDevice->bEncryptionEnable == true) {
>  		bNeedEncryption = true;
>  
> -		// get group key
> +		/* get group key */
>  		pbyBSSID = pDevice->abyBroadcastAddr;
>  		if (KeybGetTransmitKey(&(pDevice->sKey), pbyBSSID,
>  		    GROUP_KEY, &pTransmitKey) == false) {
> @@ -159,7 +159,7 @@ bool ROUTEbRelay(struct vnt_private *pDevice, unsigned char *pbySkbData,
>  			    &cbHeaderSize);
>  
>  	if (MACbIsRegBitsOn(pDevice->PortOffset, MAC_REG_PSCTL, PSCTL_PS)) {
> -		// Disable PS
> +		/* Disable PS */
>  		MACbPSWakeup(pDevice->PortOffset);
>  	}
>  
> @@ -167,7 +167,7 @@ bool ROUTEbRelay(struct vnt_private *pDevice, unsigned char *pbySkbData,
>  
>  	pLastTD = pHeadTD;
>  	for (ii = 0; ii < uMACfragNum; ii++) {
> -		// Poll Transmit the adapter
> +		/* Poll Transmit the adapter */
>  		wmb();
>  		pHeadTD->m_td0TD0.f1Owner = OWNED_BY_NIC;
>  		wmb();
> -- 
> 1.9.1
> 
> -- 
> You received this message because you are subscribed to the Google Groups "opw-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to opw-kernel+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
diff mbox

Patch

diff --git a/drivers/staging/vt6655/wroute.c b/drivers/staging/vt6655/wroute.c
index d1171fa..6606a1c 100644
--- a/drivers/staging/vt6655/wroute.c
+++ b/drivers/staging/vt6655/wroute.c
@@ -94,7 +94,7 @@  bool ROUTEbRelay(struct vnt_private *pDevice, unsigned char *pbySkbData,
 	if (pDevice->bEncryptionEnable == true) {
 		bNeedEncryption = true;
 
-		// get group key
+		/* get group key */
 		pbyBSSID = pDevice->abyBroadcastAddr;
 		if (KeybGetTransmitKey(&(pDevice->sKey), pbyBSSID,
 		    GROUP_KEY, &pTransmitKey) == false) {
@@ -159,7 +159,7 @@  bool ROUTEbRelay(struct vnt_private *pDevice, unsigned char *pbySkbData,
 			    &cbHeaderSize);
 
 	if (MACbIsRegBitsOn(pDevice->PortOffset, MAC_REG_PSCTL, PSCTL_PS)) {
-		// Disable PS
+		/* Disable PS */
 		MACbPSWakeup(pDevice->PortOffset);
 	}
 
@@ -167,7 +167,7 @@  bool ROUTEbRelay(struct vnt_private *pDevice, unsigned char *pbySkbData,
 
 	pLastTD = pHeadTD;
 	for (ii = 0; ii < uMACfragNum; ii++) {
-		// Poll Transmit the adapter
+		/* Poll Transmit the adapter */
 		wmb();
 		pHeadTD->m_td0TD0.f1Owner = OWNED_BY_NIC;
 		wmb();