diff mbox

[OPW,kernel] staging:usbip:stub_rx.c: Remove warning quoted string split across lines

Message ID 20131102120122.GA3497@himangi-Inspiron-N5110gmail.com
State New, archived
Headers show

Commit Message

HIMANGI SARAOGI Nov. 2, 2013, 12:01 p.m. UTC
This patch removes the checkpatch.pl warnings "quoted string split
across lines" in stub_rx.c by merging the quoted strings and the
ensuring that the lines are not more than 80 characters long.

Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
---
 drivers/staging/usbip/stub_rx.c |   20 ++++++++++++--------
 1 file changed, 12 insertions(+), 8 deletions(-)

Comments

Josh Triplett Nov. 2, 2013, 12:06 p.m. UTC | #1
On Sat, Nov 02, 2013 at 05:31:22PM +0530, Himangi Saraogi wrote:
> This patch removes the checkpatch.pl warnings "quoted string split
> across lines" in stub_rx.c by merging the quoted strings and the
> ensuring that the lines are not more than 80 characters long.
> 
> Signed-off-by: Himangi Saraogi <himangi774@gmail.com>

Reviewed-by: Josh Triplett <josh@joshtriplett.org>

> ---
>  drivers/staging/usbip/stub_rx.c |   20 ++++++++++++--------
>  1 file changed, 12 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/staging/usbip/stub_rx.c b/drivers/staging/usbip/stub_rx.c
> index db48a78..5d1d4a1 100644
> --- a/drivers/staging/usbip/stub_rx.c
> +++ b/drivers/staging/usbip/stub_rx.c
> @@ -102,11 +102,13 @@ static int tweak_clear_halt_cmd(struct urb *urb)
>  
>  	ret = usb_clear_halt(urb->dev, target_pipe);
>  	if (ret < 0)
> -		dev_err(&urb->dev->dev, "usb_clear_halt error: devnum %d endp "
> -			"%d ret %d\n", urb->dev->devnum, target_endp, ret);
> +		dev_err(&urb->dev->dev,
> +			"usb_clear_halt error: devnum %d endp %d ret %d\n",
> +			urb->dev->devnum, target_endp, ret);
>  	else
> -		dev_info(&urb->dev->dev, "usb_clear_halt done: devnum %d endp "
> -			 "%d\n", urb->dev->devnum, target_endp);
> +		dev_info(&urb->dev->dev,
> +			 "usb_clear_halt done: devnum %d endp %d\n",
> +			 urb->dev->devnum, target_endp);
>  
>  	return ret;
>  }
> @@ -127,11 +129,13 @@ static int tweak_set_interface_cmd(struct urb *urb)
>  
>  	ret = usb_set_interface(urb->dev, interface, alternate);
>  	if (ret < 0)
> -		dev_err(&urb->dev->dev, "usb_set_interface error: inf %u alt "
> -			"%u ret %d\n", interface, alternate, ret);
> +		dev_err(&urb->dev->dev,
> +			"usb_set_interface error: inf %u alt %u ret %d\n",
> +			interface, alternate, ret);
>  	else
> -		dev_info(&urb->dev->dev, "usb_set_interface done: inf %u alt "
> -			 "%u\n", interface, alternate);
> +		dev_info(&urb->dev->dev,
> +			"usb_set_interface done: inf %u alt %u\n",
> +			interface, alternate);
>  
>  	return ret;
>  }
> -- 
> 1.7.9.5
> 
> -- 
> You received this message because you are subscribed to the Google Groups "opw-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to opw-kernel+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
'Greg KH' Nov. 10, 2013, 7:52 p.m. UTC | #2
On Sat, Nov 02, 2013 at 05:31:22PM +0530, Himangi Saraogi wrote:
> This patch removes the checkpatch.pl warnings "quoted string split
> across lines" in stub_rx.c by merging the quoted strings and the
> ensuring that the lines are not more than 80 characters long.
> 
> Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
> Reviewed-by: Josh Triplett <josh@joshtriplett.org>

Applied, thanks.

greg k-h
diff mbox

Patch

diff --git a/drivers/staging/usbip/stub_rx.c b/drivers/staging/usbip/stub_rx.c
index db48a78..5d1d4a1 100644
--- a/drivers/staging/usbip/stub_rx.c
+++ b/drivers/staging/usbip/stub_rx.c
@@ -102,11 +102,13 @@  static int tweak_clear_halt_cmd(struct urb *urb)
 
 	ret = usb_clear_halt(urb->dev, target_pipe);
 	if (ret < 0)
-		dev_err(&urb->dev->dev, "usb_clear_halt error: devnum %d endp "
-			"%d ret %d\n", urb->dev->devnum, target_endp, ret);
+		dev_err(&urb->dev->dev,
+			"usb_clear_halt error: devnum %d endp %d ret %d\n",
+			urb->dev->devnum, target_endp, ret);
 	else
-		dev_info(&urb->dev->dev, "usb_clear_halt done: devnum %d endp "
-			 "%d\n", urb->dev->devnum, target_endp);
+		dev_info(&urb->dev->dev,
+			 "usb_clear_halt done: devnum %d endp %d\n",
+			 urb->dev->devnum, target_endp);
 
 	return ret;
 }
@@ -127,11 +129,13 @@  static int tweak_set_interface_cmd(struct urb *urb)
 
 	ret = usb_set_interface(urb->dev, interface, alternate);
 	if (ret < 0)
-		dev_err(&urb->dev->dev, "usb_set_interface error: inf %u alt "
-			"%u ret %d\n", interface, alternate, ret);
+		dev_err(&urb->dev->dev,
+			"usb_set_interface error: inf %u alt %u ret %d\n",
+			interface, alternate, ret);
 	else
-		dev_info(&urb->dev->dev, "usb_set_interface done: inf %u alt "
-			 "%u\n", interface, alternate);
+		dev_info(&urb->dev->dev,
+			"usb_set_interface done: inf %u alt %u\n",
+			interface, alternate);
 
 	return ret;
 }