diff mbox

[OPW,kernel] staging:rtl8187se: Use preferred library linux/uaccess.h over asm/uaccess.h

Message ID 20131105223718.GA16710@himangi-Inspiron-N5110gmail.com
State New, archived
Headers show

Commit Message

HIMANGI SARAOGI Nov. 5, 2013, 10:37 p.m. UTC
This patch fixees the checkpatch.pl warning "Use #include
<linux/uaccess.h> instead of <asm/uaccess.h>" in
ieee80211/ieee80211_softmac.c .

Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
---
 .../rtl8187se/ieee80211/ieee80211_softmac.c        |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Lisa Nguyen Nov. 5, 2013, 10:44 p.m. UTC | #1
On Tue, Nov 5, 2013 at 2:37 PM, Himangi Saraogi <himangi774@gmail.com> wrote:
> This patch fixees the checkpatch.pl warning "Use #include
> <linux/uaccess.h> instead of <asm/uaccess.h>" in
> ieee80211/ieee80211_softmac.c .
>
> Signed-off-by: Himangi Saraogi <himangi774@gmail.com>

Looks fine.

Reviewed-by: Lisa Nguyen <lisa@xenapiadmin.com>

> ---
>  .../rtl8187se/ieee80211/ieee80211_softmac.c        |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8187se/ieee80211/ieee80211_softmac.c b/drivers/staging/rtl8187se/ieee80211/ieee80211_softmac.c
> index a973872..9fd0082 100644
> --- a/drivers/staging/rtl8187se/ieee80211/ieee80211_softmac.c
> +++ b/drivers/staging/rtl8187se/ieee80211/ieee80211_softmac.c
> @@ -20,7 +20,7 @@
>  #include <linux/delay.h>
>  #include <linux/slab.h>
>  #include <linux/interrupt.h>
> -#include <asm/uaccess.h>
> +#include <linux/uaccess.h>
>  #include <linux/etherdevice.h>
>
>  #include "dot11d.h"
> --
> 1.7.9.5
>
> --
> You received this message because you are subscribed to the Google Groups "opw-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to opw-kernel+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
Waskiewicz Jr, Peter P Nov. 6, 2013, midnight UTC | #2
On Wed, 2013-11-06 at 04:07 +0530, Himangi Saraogi wrote:
> This patch fixees the checkpatch.pl warning "Use #include

s/fixees/fixes/

> <linux/uaccess.h> instead of <asm/uaccess.h>" in
> ieee80211/ieee80211_softmac.c .
> 
> Signed-off-by: Himangi Saraogi <himangi774@gmail.com>

I build-tested this, it looks fine.  Just a small adjustment in the
commit message as pointed out above.

> ---
>  .../rtl8187se/ieee80211/ieee80211_softmac.c        |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8187se/ieee80211/ieee80211_softmac.c b/drivers/staging/rtl8187se/ieee80211/ieee80211_softmac.c
> index a973872..9fd0082 100644
> --- a/drivers/staging/rtl8187se/ieee80211/ieee80211_softmac.c
> +++ b/drivers/staging/rtl8187se/ieee80211/ieee80211_softmac.c
> @@ -20,7 +20,7 @@
>  #include <linux/delay.h>
>  #include <linux/slab.h>
>  #include <linux/interrupt.h>
> -#include <asm/uaccess.h>
> +#include <linux/uaccess.h>
>  #include <linux/etherdevice.h>
>  
>  #include "dot11d.h"
> -- 
> 1.7.9.5
>
diff mbox

Patch

diff --git a/drivers/staging/rtl8187se/ieee80211/ieee80211_softmac.c b/drivers/staging/rtl8187se/ieee80211/ieee80211_softmac.c
index a973872..9fd0082 100644
--- a/drivers/staging/rtl8187se/ieee80211/ieee80211_softmac.c
+++ b/drivers/staging/rtl8187se/ieee80211/ieee80211_softmac.c
@@ -20,7 +20,7 @@ 
 #include <linux/delay.h>
 #include <linux/slab.h>
 #include <linux/interrupt.h>
-#include <asm/uaccess.h>
+#include <linux/uaccess.h>
 #include <linux/etherdevice.h>
 
 #include "dot11d.h"