diff mbox

[OPW,kernel] Staging:rtl8187se: Insert spaces after commas

Message ID 20131106112633.GA3681@himangi-Inspiron-N5110gmail.com
State New, archived
Headers show

Commit Message

HIMANGI SARAOGI Nov. 6, 2013, 11:26 a.m. UTC
This patch fixes the checkpatch.pl warnings
space required after that ',' in ieee80211/ieee80211_softmac.c

Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
---
 .../rtl8187se/ieee80211/ieee80211_softmac.c        |   12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

Comments

Waskiewicz Jr, Peter P Nov. 7, 2013, 7:27 a.m. UTC | #1
On Wed, 2013-11-06 at 16:56 +0530, Himangi Saraogi wrote:
> This patch fixes the checkpatch.pl warnings
> space required after that ',' in ieee80211/ieee80211_softmac.c
> 
> Signed-off-by: Himangi Saraogi <himangi774@gmail.com>

This looks ok.  Can you put a separate patch together to clean up the C
++-style comments and the one line that's too long?

Reviewed-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>

> ---
>  .../rtl8187se/ieee80211/ieee80211_softmac.c        |   12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/staging/rtl8187se/ieee80211/ieee80211_softmac.c b/drivers/staging/rtl8187se/ieee80211/ieee80211_softmac.c
> index 9fd0082..eddf39f 100644
> --- a/drivers/staging/rtl8187se/ieee80211/ieee80211_softmac.c
> +++ b/drivers/staging/rtl8187se/ieee80211/ieee80211_softmac.c
> @@ -25,12 +25,12 @@
>  
>  #include "dot11d.h"
>  u8 rsn_authen_cipher_suite[16][4] = {
> -	{0x00,0x0F,0xAC,0x00}, //Use group key, //Reserved
> -	{0x00,0x0F,0xAC,0x01}, //WEP-40         //RSNA default
> -	{0x00,0x0F,0xAC,0x02}, //TKIP           //NONE		//{used just as default}
> -	{0x00,0x0F,0xAC,0x03}, //WRAP-historical
> -	{0x00,0x0F,0xAC,0x04}, //CCMP
> -	{0x00,0x0F,0xAC,0x05}, //WEP-104
> +	{0x00, 0x0F, 0xAC, 0x00}, //Use group key, //Reserved
> +	{0x00, 0x0F, 0xAC, 0x01}, //WEP-40         //RSNA default
> +	{0x00, 0x0F, 0xAC, 0x02}, //TKIP           //NONE		//{used just as default}
> +	{0x00, 0x0F, 0xAC, 0x03}, //WRAP-historical
> +	{0x00, 0x0F, 0xAC, 0x04}, //CCMP
> +	{0x00, 0x0F, 0xAC, 0x05}, //WEP-104
>  };
>  
>  short ieee80211_is_54g(const struct ieee80211_network *net)
> -- 
> 1.7.9.5
>
Greg KH Nov. 10, 2013, 5:07 p.m. UTC | #2
On Wed, Nov 06, 2013 at 04:56:33PM +0530, Himangi Saraogi wrote:
> This patch fixes the checkpatch.pl warnings
> space required after that ',' in ieee80211/ieee80211_softmac.c
> 
> Signed-off-by: Himangi Saraogi <himangi774@gmail.com>

Applied, thanks.

greg k-h
diff mbox

Patch

diff --git a/drivers/staging/rtl8187se/ieee80211/ieee80211_softmac.c b/drivers/staging/rtl8187se/ieee80211/ieee80211_softmac.c
index 9fd0082..eddf39f 100644
--- a/drivers/staging/rtl8187se/ieee80211/ieee80211_softmac.c
+++ b/drivers/staging/rtl8187se/ieee80211/ieee80211_softmac.c
@@ -25,12 +25,12 @@ 
 
 #include "dot11d.h"
 u8 rsn_authen_cipher_suite[16][4] = {
-	{0x00,0x0F,0xAC,0x00}, //Use group key, //Reserved
-	{0x00,0x0F,0xAC,0x01}, //WEP-40         //RSNA default
-	{0x00,0x0F,0xAC,0x02}, //TKIP           //NONE		//{used just as default}
-	{0x00,0x0F,0xAC,0x03}, //WRAP-historical
-	{0x00,0x0F,0xAC,0x04}, //CCMP
-	{0x00,0x0F,0xAC,0x05}, //WEP-104
+	{0x00, 0x0F, 0xAC, 0x00}, //Use group key, //Reserved
+	{0x00, 0x0F, 0xAC, 0x01}, //WEP-40         //RSNA default
+	{0x00, 0x0F, 0xAC, 0x02}, //TKIP           //NONE		//{used just as default}
+	{0x00, 0x0F, 0xAC, 0x03}, //WRAP-historical
+	{0x00, 0x0F, 0xAC, 0x04}, //CCMP
+	{0x00, 0x0F, 0xAC, 0x05}, //WEP-104
 };
 
 short ieee80211_is_54g(const struct ieee80211_network *net)