diff mbox

[OPW,kernel] staging:wlags49_h2: Fix sparse warnings in sta_h25.c

Message ID 20131107224241.GA3783@himangi-Inspiron-N5110gmail.com
State New, archived
Headers show

Commit Message

HIMANGI SARAOGI Nov. 7, 2013, 10:42 p.m. UTC
This patch fixes sparse warnings "Using plain integer as NULL pointer" in
sta_h25.c

Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
---
 drivers/staging/wlags49_h2/sta_h25.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Waskiewicz Jr, Peter P Nov. 7, 2013, 10:57 p.m. UTC | #1
On Fri, 2013-11-08 at 04:12 +0530, Himangi Saraogi wrote:
> This patch fixes sparse warnings "Using plain integer as NULL pointer" in
> sta_h25.c
> 
> Signed-off-by: Himangi Saraogi <himangi774@gmail.com>

Looks ok to me at a glance.  Was this build-tested?

Reviewed-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>

> ---
>  drivers/staging/wlags49_h2/sta_h25.c |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/wlags49_h2/sta_h25.c b/drivers/staging/wlags49_h2/sta_h25.c
> index 5b6f670..eccd780 100644
> --- a/drivers/staging/wlags49_h2/sta_h25.c
> +++ b/drivers/staging/wlags49_h2/sta_h25.c
> @@ -5211,7 +5211,7 @@ static const CFG_PROG_STRCT fw_image_code[] = {
>  		0000,
>   	0x000F429B,					// Start execution address
>  	},
> -	{ 0000, 0000, 0000, 0000, 00000000, 0000, 00000000}
> +	{ 0000, 0000, 0000, 0000, 00000000, 0000, NULL}
>  };
>  
>  static const CFG_RANGE20_STRCT fw_image_infocompat[] = {
> @@ -5247,8 +5247,8 @@ memimage fw_image = {
>  	"FUPU7D37dhfwci\001C",			//signature, <format number>, C/Bin type
>  	(CFG_PROG_STRCT *) fw_image_code,
>  	0x000F429B,
> -	00000000,					//(dummy) pdaplug
> -	00000000,					//(dummy) priplug
> +	NULL,					//(dummy) pdaplug
> +	NULL,					//(dummy) priplug
>  	(CFG_RANGE20_STRCT *) fw_image_infocompat,
>  	(CFG_IDENTITY_STRCT *) fw_image_infoidentity,
>  };
> -- 
> 1.7.9.5
>
HIMANGI SARAOGI Nov. 9, 2013, 7:17 p.m. UTC | #2
On Friday, November 8, 2013 4:27:45 AM UTC+5:30, Waskiewicz Jr, Peter P 
wrote:
>
> On Fri, 2013-11-08 at 04:12 +0530, Himangi Saraogi wrote: 
> > This patch fixes sparse warnings "Using plain integer as NULL pointer" 
> in 
> > sta_h25.c 
> > 
> > Signed-off-by: Himangi Saraogi <himan...@gmail.com <javascript:>> 
>
> Looks ok to me at a glance.  Was this build-tested? 
>
It was build-tested and compiled without errors. 

Thanks.
Himangi
gregkh@linuxfoundation.org Nov. 10, 2013, 8:26 p.m. UTC | #3
On Fri, Nov 08, 2013 at 04:12:41AM +0530, Himangi Saraogi wrote:
> This patch fixes sparse warnings "Using plain integer as NULL pointer" in
> sta_h25.c
> 
> Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
> Reviewed-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>

Applied, thanks.

greg k-h
diff mbox

Patch

diff --git a/drivers/staging/wlags49_h2/sta_h25.c b/drivers/staging/wlags49_h2/sta_h25.c
index 5b6f670..eccd780 100644
--- a/drivers/staging/wlags49_h2/sta_h25.c
+++ b/drivers/staging/wlags49_h2/sta_h25.c
@@ -5211,7 +5211,7 @@  static const CFG_PROG_STRCT fw_image_code[] = {
 		0000,
  	0x000F429B,					// Start execution address
 	},
-	{ 0000, 0000, 0000, 0000, 00000000, 0000, 00000000}
+	{ 0000, 0000, 0000, 0000, 00000000, 0000, NULL}
 };
 
 static const CFG_RANGE20_STRCT fw_image_infocompat[] = {
@@ -5247,8 +5247,8 @@  memimage fw_image = {
 	"FUPU7D37dhfwci\001C",			//signature, <format number>, C/Bin type
 	(CFG_PROG_STRCT *) fw_image_code,
 	0x000F429B,
-	00000000,					//(dummy) pdaplug
-	00000000,					//(dummy) priplug
+	NULL,					//(dummy) pdaplug
+	NULL,					//(dummy) priplug
 	(CFG_RANGE20_STRCT *) fw_image_infocompat,
 	(CFG_IDENTITY_STRCT *) fw_image_infoidentity,
 };