diff mbox

[OPW,kernel] staging:rtl8187se: Remove unused variable

Message ID 20140310183505.GA25926@himangi-Inspiron-N5110gmail.com
State New, archived
Headers show

Commit Message

HIMANGI SARAOGI March 10, 2014, 6:35 p.m. UTC
This patch disgards the variable declaration and initialization of
rsn_authen_cipher_suite as it is not used anywhere throughout
the kernel.

Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
---
 .../rtl8187se/ieee80211/ieee80211_softmac.c        |    8 --------
 1 file changed, 8 deletions(-)

Comments

Paul E. McKenney March 10, 2014, 7:47 p.m. UTC | #1
On Tue, Mar 11, 2014 at 12:05:05AM +0530, Himangi Saraogi wrote:
> This patch disgards the variable declaration and initialization of
> rsn_authen_cipher_suite as it is not used anywhere throughout
> the kernel.
> 
> Signed-off-by: Himangi Saraogi <himangi774@gmail.com>

Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>

> ---
>  .../rtl8187se/ieee80211/ieee80211_softmac.c        |    8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/drivers/staging/rtl8187se/ieee80211/ieee80211_softmac.c b/drivers/staging/rtl8187se/ieee80211/ieee80211_softmac.c
> index 65cdec4..db6b2ad 100644
> --- a/drivers/staging/rtl8187se/ieee80211/ieee80211_softmac.c
> +++ b/drivers/staging/rtl8187se/ieee80211/ieee80211_softmac.c
> @@ -24,14 +24,6 @@
>  #include <linux/etherdevice.h>
> 
>  #include "dot11d.h"
> -static u8 rsn_authen_cipher_suite[16][4] = {
> -	{0x00, 0x0F, 0xAC, 0x00}, //Use group key, //Reserved
> -	{0x00, 0x0F, 0xAC, 0x01}, //WEP-40         //RSNA default
> -	{0x00, 0x0F, 0xAC, 0x02}, //TKIP           //NONE		//{used just as default}
> -	{0x00, 0x0F, 0xAC, 0x03}, //WRAP-historical
> -	{0x00, 0x0F, 0xAC, 0x04}, //CCMP
> -	{0x00, 0x0F, 0xAC, 0x05}, //WEP-104
> -};
> 
>  short ieee80211_is_54g(const struct ieee80211_network *net)
>  {
> -- 
> 1.7.9.5
> 
> -- 
> You received this message because you are subscribed to the Google Groups "opw-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to opw-kernel+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
Greg Kroah-Hartman March 18, 2014, 5:05 p.m. UTC | #2
On Tue, Mar 11, 2014 at 12:05:05AM +0530, Himangi Saraogi wrote:
> This patch disgards the variable declaration and initialization of
> rsn_authen_cipher_suite as it is not used anywhere throughout
> the kernel.
> 
> Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
> Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> ---
>  .../rtl8187se/ieee80211/ieee80211_softmac.c        |    8 --------
>  1 file changed, 8 deletions(-)

This patch is already applied, right?

thanks,

greg k-h
HIMANGI SARAOGI March 18, 2014, 5:30 p.m. UTC | #3
On Tuesday, March 18, 2014 10:35:01 PM UTC+5:30, Greg Kroah-Hartman wrote:
>
> On Tue, Mar 11, 2014 at 12:05:05AM +0530, Himangi Saraogi wrote: 
> > This patch disgards the variable declaration and initialization of 
> > rsn_authen_cipher_suite as it is not used anywhere throughout 
> > the kernel. 
> > 
> > Signed-off-by: Himangi Saraogi <himan...@gmail.com <javascript:>> 
> > Acked-by: Paul E. McKenney <pau...@linux.vnet.ibm.com <javascript:>> 
> > --- 
> >  .../rtl8187se/ieee80211/ieee80211_softmac.c        |    8 -------- 
> >  1 file changed, 8 deletions(-) 
>
> This patch is already applied, right? 
>
> Yes it is. But I had sent in the patch on a refreshed  tree and even the 
git log does not show
such a change. Not much of a worry, but would like to know how a change can 
be made without it 
being reflected in git log.

> thanks, 
>
> greg k-h 
>
Greg Kroah-Hartman March 18, 2014, 6:26 p.m. UTC | #4
On Tue, Mar 18, 2014 at 10:30:02AM -0700, Himangi Saraogi wrote:
> 
> 
> On Tuesday, March 18, 2014 10:35:01 PM UTC+5:30, Greg Kroah-Hartman wrote:
> 
>     On Tue, Mar 11, 2014 at 12:05:05AM +0530, Himangi Saraogi wrote:
>     > This patch disgards the variable declaration and initialization of
>     > rsn_authen_cipher_suite as it is not used anywhere throughout
>     > the kernel.
>     >
>     > Signed-off-by: Himangi Saraogi <himan...@gmail.com>
>     > Acked-by: Paul E. McKenney <pau...@linux.vnet.ibm.com>
>     > ---
>     >  .../rtl8187se/ieee80211/ieee80211_softmac.c        |    8 --------
>     >  1 file changed, 8 deletions(-)
> 
>     This patch is already applied, right?
> 
> 
> Yes it is. But I had sent in the patch on a refreshed  tree and even the git
> log does not show
> such a change. Not much of a worry, but would like to know how a change can be
> made without it
> being reflected in git log.

It's there somewhere, try using 'git blame' on the file and see what
commit changed the lines.

greg k-h
diff mbox

Patch

diff --git a/drivers/staging/rtl8187se/ieee80211/ieee80211_softmac.c b/drivers/staging/rtl8187se/ieee80211/ieee80211_softmac.c
index 65cdec4..db6b2ad 100644
--- a/drivers/staging/rtl8187se/ieee80211/ieee80211_softmac.c
+++ b/drivers/staging/rtl8187se/ieee80211/ieee80211_softmac.c
@@ -24,14 +24,6 @@ 
 #include <linux/etherdevice.h>
 
 #include "dot11d.h"
-static u8 rsn_authen_cipher_suite[16][4] = {
-	{0x00, 0x0F, 0xAC, 0x00}, //Use group key, //Reserved
-	{0x00, 0x0F, 0xAC, 0x01}, //WEP-40         //RSNA default
-	{0x00, 0x0F, 0xAC, 0x02}, //TKIP           //NONE		//{used just as default}
-	{0x00, 0x0F, 0xAC, 0x03}, //WRAP-historical
-	{0x00, 0x0F, 0xAC, 0x04}, //CCMP
-	{0x00, 0x0F, 0xAC, 0x05}, //WEP-104
-};
 
 short ieee80211_is_54g(const struct ieee80211_network *net)
 {