diff mbox

[OPW,kernel] staging:unisys: Fix sparse warnings

Message ID 20140316205711.GA14747@himangi-Inspiron-N5110gmail.com
State New, archived
Headers show

Commit Message

HIMANGI SARAOGI March 16, 2014, 8:57 p.m. UTC
This patch fixes the following sparse warnings:
drivers/staging/unisys/virtpci/virtpci.c:258:9: warning: constant 0x4000000000000000 is so big it is long
drivers/staging/unisys/virtpci/virtpci.c:277:17: warning: constant 0x4000000000000000 is so big it is long
drivers/staging/unisys/virtpci/virtpci.c:285:9: warning: constant 0x4000000000000000 is so big it is long
drivers/staging/unisys/virtpci/virtpci.c:318:9: warning: constant 0x4000000000000000 is so big it is long
drivers/staging/unisys/virtpci/virtpci.c:322:17: warning: constant 0x4000000000000000 is so big it is long
drivers/staging/unisys/virtpci/virtpci.c:338:17: warning: constant 0x4000000000000000 is so big it is long
drivers/staging/unisys/virtpci/virtpci.c:366:9: warning: constant 0x4000000000000000 is so big it is long
drivers/staging/unisys/virtpci/virtpci.c:370:17: warning: constant 0x4000000000000000 is so big it is long
drivers/staging/unisys/virtpci/virtpci.c:391:17: warning: constant 0x4000000000000000 is so big it is long
drivers/staging/unisys/virtpci/virtpci.c:810:9: warning: constant 0x4000000000000000 is so big it is long
drivers/staging/unisys/virtpci/virtpci.c:836:25: warning: constant 0x4000000000000000 is so big it is long
drivers/staging/unisys/virtpci/virtpci.c:841:9: warning: constant 0x4000000000000000 is so big it is long
drivers/staging/unisys/virtpci/virtpci.c:901:9: warning: constant 0x4000000000000000 is so big it is long
drivers/staging/unisys/virtpci/virtpci.c:906:17: warning: constant 0x4000000000000000 is so big it is long
drivers/staging/unisys/virtpci/virtpci.c:915:17: warning: constant 0x4000000000000000 is so big it is long
drivers/staging/unisys/virtpci/virtpci.c:978:17: warning: constant 0x4000000000000000 is so big it is long
drivers/staging/unisys/virtpci/virtpci.c:1048:9: warning: constant 0x4000000000000000 is so big it is long
drivers/staging/unisys/virtpci/virtpci.c:1676:9: warning: constant 0x4000000000000000 is so big it is long
drivers/staging/unisys/virtpci/virtpci.c:1684:17: warning: constant 0x4000000000000000 is so big it is long
drivers/staging/unisys/virtpci/virtpci.c:1698:17: warning: constant 0x4000000000000000 is so big it is long
drivers/staging/unisys/virtpci/virtpci.c:1707:17: warning: constant 0x4000000000000000 is so big it is long
drivers/staging/unisys/virtpci/virtpci.c:1722:9: warning: constant 0x4000000000000000 is so big it is long

Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
---
 .../unisys/common-spar/include/vmcallinterface.h   |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

gregkh@linuxfoundation.org March 18, 2014, 7:04 p.m. UTC | #1
On Mon, Mar 17, 2014 at 02:27:11AM +0530, Himangi Saraogi wrote:
> This patch fixes the following sparse warnings:
> drivers/staging/unisys/virtpci/virtpci.c:258:9: warning: constant 0x4000000000000000 is so big it is long
> drivers/staging/unisys/virtpci/virtpci.c:277:17: warning: constant 0x4000000000000000 is so big it is long
> drivers/staging/unisys/virtpci/virtpci.c:285:9: warning: constant 0x4000000000000000 is so big it is long
> drivers/staging/unisys/virtpci/virtpci.c:318:9: warning: constant 0x4000000000000000 is so big it is long
> drivers/staging/unisys/virtpci/virtpci.c:322:17: warning: constant 0x4000000000000000 is so big it is long
> drivers/staging/unisys/virtpci/virtpci.c:338:17: warning: constant 0x4000000000000000 is so big it is long
> drivers/staging/unisys/virtpci/virtpci.c:366:9: warning: constant 0x4000000000000000 is so big it is long
> drivers/staging/unisys/virtpci/virtpci.c:370:17: warning: constant 0x4000000000000000 is so big it is long
> drivers/staging/unisys/virtpci/virtpci.c:391:17: warning: constant 0x4000000000000000 is so big it is long
> drivers/staging/unisys/virtpci/virtpci.c:810:9: warning: constant 0x4000000000000000 is so big it is long
> drivers/staging/unisys/virtpci/virtpci.c:836:25: warning: constant 0x4000000000000000 is so big it is long
> drivers/staging/unisys/virtpci/virtpci.c:841:9: warning: constant 0x4000000000000000 is so big it is long
> drivers/staging/unisys/virtpci/virtpci.c:901:9: warning: constant 0x4000000000000000 is so big it is long
> drivers/staging/unisys/virtpci/virtpci.c:906:17: warning: constant 0x4000000000000000 is so big it is long
> drivers/staging/unisys/virtpci/virtpci.c:915:17: warning: constant 0x4000000000000000 is so big it is long
> drivers/staging/unisys/virtpci/virtpci.c:978:17: warning: constant 0x4000000000000000 is so big it is long
> drivers/staging/unisys/virtpci/virtpci.c:1048:9: warning: constant 0x4000000000000000 is so big it is long
> drivers/staging/unisys/virtpci/virtpci.c:1676:9: warning: constant 0x4000000000000000 is so big it is long
> drivers/staging/unisys/virtpci/virtpci.c:1684:17: warning: constant 0x4000000000000000 is so big it is long
> drivers/staging/unisys/virtpci/virtpci.c:1698:17: warning: constant 0x4000000000000000 is so big it is long
> drivers/staging/unisys/virtpci/virtpci.c:1707:17: warning: constant 0x4000000000000000 is so big it is long
> drivers/staging/unisys/virtpci/virtpci.c:1722:9: warning: constant 0x4000000000000000 is so big it is long
> 
> Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
> ---
>  .../unisys/common-spar/include/vmcallinterface.h   |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/unisys/common-spar/include/vmcallinterface.h b/drivers/staging/unisys/common-spar/include/vmcallinterface.h
> index bd8944a..f333b82 100644
> --- a/drivers/staging/unisys/common-spar/include/vmcallinterface.h
> +++ b/drivers/staging/unisys/common-spar/include/vmcallinterface.h
> @@ -32,7 +32,7 @@
>  #endif	/*  */
>  
>  /* define subsystem number for AppOS, used in uislib driver  */
> -#define MDS_APPOS 0x4000000000000000	/* subsystem = 62 - AppOS */
> +#define MDS_APPOS _AC(0x4000000000000000, UL)	/* subsystem = 62 - AppOS */

As this isn't assembly code, no need to use _AC() here at all, just
properly cast the value.

thanks,

greg k-h
diff mbox

Patch

diff --git a/drivers/staging/unisys/common-spar/include/vmcallinterface.h b/drivers/staging/unisys/common-spar/include/vmcallinterface.h
index bd8944a..f333b82 100644
--- a/drivers/staging/unisys/common-spar/include/vmcallinterface.h
+++ b/drivers/staging/unisys/common-spar/include/vmcallinterface.h
@@ -32,7 +32,7 @@ 
 #endif	/*  */
 
 /* define subsystem number for AppOS, used in uislib driver  */
-#define MDS_APPOS 0x4000000000000000	/* subsystem = 62 - AppOS */
+#define MDS_APPOS _AC(0x4000000000000000, UL)	/* subsystem = 62 - AppOS */
 typedef enum {		/* VMCALL identification tuples  */
 	    /* Note: when a new VMCALL is added:
 	     * - the 1st 2 hex digits correspond to one of the