diff mbox

[OPW,kernel] staging:vt6655:Fix checkpatch warning

Message ID 20140915062634.GA18111@kato-K52F
State New, archived
Headers show

Commit Message

Rajbinder Brar Sept. 15, 2014, 6:26 a.m. UTC
This fixes the following checkpatch.pl warning
WARNING: line over 80 characters

Signed-off-by: Rajbinder Brar <brar.rajbinder@gmail.com>
---
 drivers/staging/vt6655/80211hdr.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Julia Lawall Sept. 15, 2014, 6:37 a.m. UTC | #1
On Mon, 15 Sep 2014, Rajbinder Brar wrote:

> This fixes the following checkpatch.pl warning
> WARNING: line over 80 characters
>
> Signed-off-by: Rajbinder Brar <brar.rajbinder@gmail.com>
> ---
>  drivers/staging/vt6655/80211hdr.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/vt6655/80211hdr.h b/drivers/staging/vt6655/80211hdr.h
> index e05d135..568c320 100644
> --- a/drivers/staging/vt6655/80211hdr.h
> +++ b/drivers/staging/vt6655/80211hdr.h
> @@ -83,7 +83,8 @@
>  #define WLAN_RATES_MAXLEN_11B       4
>  #define WLAN_RSN_MAXLEN             32
>  #define WLAN_DATA_MAXLEN            2312
> -#define WLAN_A3FR_MAXLEN            (WLAN_HDR_ADDR3_LEN + WLAN_DATA_MAXLEN + WLAN_CRC_LEN)
> +#define WLAN_A3FR_MAXLEN            (WLAN_HDR_ADDR3_LEN + WLAN_DATA_MAXLEN + \
> +		WLAN_CRC_LEN)

The result does not look very nice either.  Either line up WLAN_CRC_LEN
with WLAN_HDR_ADDR3_LEN, or just drop the alignment with the prior
#defines and put the whole thing on one line.  Maybe the first option is
better.

When you send a new version, remember to state what you have changed since
the revious patch under the ---

julia

>  #define WLAN_BEACON_FR_MAXLEN       WLAN_A3FR_MAXLEN
>  #define WLAN_ATIM_FR_MAXLEN         (WLAN_HDR_ADDR3_LEN + 0)
> --
> 1.9.1
>
> --
> You received this message because you are subscribed to the Google Groups "opw-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to opw-kernel+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
diff mbox

Patch

diff --git a/drivers/staging/vt6655/80211hdr.h b/drivers/staging/vt6655/80211hdr.h
index e05d135..568c320 100644
--- a/drivers/staging/vt6655/80211hdr.h
+++ b/drivers/staging/vt6655/80211hdr.h
@@ -83,7 +83,8 @@ 
 #define WLAN_RATES_MAXLEN_11B       4
 #define WLAN_RSN_MAXLEN             32
 #define WLAN_DATA_MAXLEN            2312
-#define WLAN_A3FR_MAXLEN            (WLAN_HDR_ADDR3_LEN + WLAN_DATA_MAXLEN + WLAN_CRC_LEN)
+#define WLAN_A3FR_MAXLEN            (WLAN_HDR_ADDR3_LEN + WLAN_DATA_MAXLEN + \
+		WLAN_CRC_LEN)
 
 #define WLAN_BEACON_FR_MAXLEN       WLAN_A3FR_MAXLEN
 #define WLAN_ATIM_FR_MAXLEN         (WLAN_HDR_ADDR3_LEN + 0)