diff mbox

[OPW,kernel,v2] staging: rtl8192u: Delete 'fwSendNullPacket' function in r819xU_firmware.c

Message ID 4b39163019a11540446da3242b5ca8b926dac03f.1395138039.git.anarey@gmail.com
State New, archived
Headers show

Commit Message

Ana Rey March 18, 2014, 11 a.m. UTC
Delete the fwSendNullPacket function that is not used in anywhere in
the driver.

Fix sparse warnings:
drivers/staging/rtl8192u/r819xU_firmware.c:109:1: warning: symbol 'fwSendNullPacket' was not declared. Should it be static?

Signed-off-by: Ana Rey <anarey@gmail.com>
---
[Changes in V2:]
I sync up with Greg's tree as Peter P Waskiewicz Jr suggested me.
Also, I fix descriptions and subject in this patch.

 drivers/staging/rtl8192u/r819xU_firmware.c | 40 ------------------------------
 1 file changed, 40 deletions(-)

Comments

gregkh@linuxfoundation.org March 18, 2014, 6:10 p.m. UTC | #1
On Tue, Mar 18, 2014 at 12:00:19PM +0100, Ana Rey wrote:
> Delete the fwSendNullPacket function that is not used in anywhere in
> the driver.
> 
> Fix sparse warnings:
> drivers/staging/rtl8192u/r819xU_firmware.c:109:1: warning: symbol 'fwSendNullPacket' was not declared. Should it be static?
> 
> Signed-off-by: Ana Rey <anarey@gmail.com>
> ---
> [Changes in V2:]
> I sync up with Greg's tree as Peter P Waskiewicz Jr suggested me.
> Also, I fix descriptions and subject in this patch.
> 
>  drivers/staging/rtl8192u/r819xU_firmware.c | 40 ------------------------------
>  1 file changed, 40 deletions(-)

Your  "v2" patches don't have the number of the patch (1/5, 2/5, etc.)
so I don't know what order to apply them in :(

Can you please resend these after fixing that?

thanks,

greg k-h
diff mbox

Patch

diff --git a/drivers/staging/rtl8192u/r819xU_firmware.c b/drivers/staging/rtl8192u/r819xU_firmware.c
index edb842c..ecfb665 100644
--- a/drivers/staging/rtl8192u/r819xU_firmware.c
+++ b/drivers/staging/rtl8192u/r819xU_firmware.c
@@ -105,46 +105,6 @@  static bool fw_download_code(struct net_device *dev, u8 *code_virtual_address,
 
 }
 
-bool
-fwSendNullPacket(
-	struct net_device *dev,
-	u32			Length
-)
-{
-	bool	rtStatus = true;
-	struct r8192_priv   *priv = ieee80211_priv(dev);
-	struct sk_buff	    *skb;
-	cb_desc		    *tcb_desc;
-	unsigned char	    *ptr_buf;
-	bool	bLastInitPacket = false;
-
-	//PlatformAcquireSpinLock(Adapter, RT_TX_SPINLOCK);
-
-	//Get TCB and local buffer from common pool. (It is shared by CmdQ, MgntQ, and USB coalesce DataQ)
-	skb  = dev_alloc_skb(Length+ 4);
-	memcpy((unsigned char *)(skb->cb),&dev,sizeof(dev));
-	tcb_desc = (cb_desc *)(skb->cb + MAX_DEV_ADDR_SIZE);
-	tcb_desc->queue_index = TXCMD_QUEUE;
-	tcb_desc->bCmdOrInit = DESC_PACKET_TYPE_INIT;
-	tcb_desc->bLastIniPkt = bLastInitPacket;
-	ptr_buf = skb_put(skb, Length);
-	memset(ptr_buf,0,Length);
-	tcb_desc->txbuf_size= (u16)Length;
-
-	if (!priv->ieee80211->check_nic_enough_desc(dev,tcb_desc->queue_index)||
-			(!skb_queue_empty(&priv->ieee80211->skb_waitQ[tcb_desc->queue_index]))||\
-			(priv->ieee80211->queue_stop) ) {
-			RT_TRACE(COMP_FIRMWARE,"===================NULL packet==================================> tx full!\n");
-			skb_queue_tail(&priv->ieee80211->skb_waitQ[tcb_desc->queue_index], skb);
-		} else {
-			priv->ieee80211->softmac_hard_start_xmit(skb,dev);
-		}
-
-	//PlatformReleaseSpinLock(Adapter, RT_TX_SPINLOCK);
-	return rtStatus;
-}
-
-
 //-----------------------------------------------------------------------------
 // Procedure:    Check whether main code is download OK. If OK, turn on CPU
 //