diff mbox

Resend: [OPW kernel] [PATCH] staging: bcm: Fix line over 80 characters.

Message ID CAFEh7=monwJE37=qTbYFxtwk9_MArJ7=hE=56orJ0StEkvwtVg@mail.gmail.com
State New, archived
Headers show

Commit Message

Heena Sirwani March 16, 2014, 4:51 p.m. UTC
Fix checkpatch.pl issues with line over 80 characters in Adapter.h

Signed-off-by: Heena Sirwani <heenasirwani@example.com>
---
 drivers/staging/bcm/Adapter.h |    6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

        struct {
                ULONG ulIpv6Addr[MAX_IP_RANGE_LENGTH * 4]; /* Source Ip
Address Range */

Comments

Paul E. McKenney March 17, 2014, 5:52 p.m. UTC | #1
On Sun, Mar 16, 2014 at 10:21:38PM +0530, Heena Sirwani wrote:
> Fix checkpatch.pl issues with line over 80 characters in Adapter.h
> 
> Signed-off-by: Heena Sirwani <heenasirwani@example.com>
> ---
>  drivers/staging/bcm/Adapter.h |    6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/bcm/Adapter.h b/drivers/staging/bcm/Adapter.h
> index f0d6f0c..1b2d9f3 100644
> --- a/drivers/staging/bcm/Adapter.h
> +++ b/drivers/staging/bcm/Adapter.h
> @@ -37,8 +37,10 @@ struct bcm_link_request {
> 
>  union u_ip_address {
>         struct {
> -               ULONG ulIpv4Addr[MAX_IP_RANGE_LENGTH]; /* Source Ip Address
> Range */
> -               ULONG ulIpv4Mask[MAX_IP_RANGE_LENGTH]; /* Source Ip Mask
> Address Range */
> +               /* Source Ip Address Range */
> +               ULONG ulIpv4Addr[MAX_IP_RANGE_LENGTH];
> +                /* Source Ip Mask Address Range */

Why the extra indent for the above line?

> +               ULONG ulIpv4Mask[MAX_IP_RANGE_LENGTH];

Please also change the spaces to tabs, possibly in a separate patch.

>         };
>         struct {
>                 ULONG ulIpv6Addr[MAX_IP_RANGE_LENGTH * 4]; /* Source Ip
> Address Range */
> 
> -- 
> You received this message because you are subscribed to the Google Groups "opw-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to opw-kernel+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
Sarah Sharp March 17, 2014, 7:58 p.m. UTC | #2
Please put "Resend" in brackets.  The git tools will ignore all words in
brackets, which means Resend will now be in the patch short description
(which is not what you want).

So, when you generate the patch, run:

git format-patch --subject-prefix="PATCH RESEND"

Or make sure when you edit the patch subject by hand that it says
something like:

[PATCH RESEND] staging: bcm: Fix line over 80 characters.

Otherwise, this patch looks fine.

Acked-by: Sarah Sharp <sarah.a.sharp@linux.intel.com>

Please add that acked-by line below your Signed-off-by line below.

On Sun, Mar 16, 2014 at 10:21:38PM +0530, Heena Sirwani wrote:
> Fix checkpatch.pl issues with line over 80 characters in Adapter.h
> 
> Signed-off-by: Heena Sirwani <heenasirwani@example.com>
> ---
>  drivers/staging/bcm/Adapter.h |    6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/bcm/Adapter.h b/drivers/staging/bcm/Adapter.h
> index f0d6f0c..1b2d9f3 100644
> --- a/drivers/staging/bcm/Adapter.h
> +++ b/drivers/staging/bcm/Adapter.h
> @@ -37,8 +37,10 @@ struct bcm_link_request {
> 
>  union u_ip_address {
>         struct {
> -               ULONG ulIpv4Addr[MAX_IP_RANGE_LENGTH]; /* Source Ip Address
> Range */
> -               ULONG ulIpv4Mask[MAX_IP_RANGE_LENGTH]; /* Source Ip Mask
> Address Range */
> +               /* Source Ip Address Range */
> +               ULONG ulIpv4Addr[MAX_IP_RANGE_LENGTH];
> +                /* Source Ip Mask Address Range */
> +               ULONG ulIpv4Mask[MAX_IP_RANGE_LENGTH];
>         };
>         struct {
>                 ULONG ulIpv6Addr[MAX_IP_RANGE_LENGTH * 4]; /* Source Ip
> Address Range */
> 
> -- 
> You received this message because you are subscribed to the Google Groups "opw-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to opw-kernel+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
Sarah Sharp March 17, 2014, 7:58 p.m. UTC | #3
On Sun, Mar 16, 2014 at 10:21:38PM +0530, Heena Sirwani wrote:
> Fix checkpatch.pl issues with line over 80 characters in Adapter.h
> 
> Signed-off-by: Heena Sirwani <heenasirwani@example.com>

Ah, this email is wrong as well, which is why you sent a second version,
correct?

> ---
>  drivers/staging/bcm/Adapter.h |    6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/bcm/Adapter.h b/drivers/staging/bcm/Adapter.h
> index f0d6f0c..1b2d9f3 100644
> --- a/drivers/staging/bcm/Adapter.h
> +++ b/drivers/staging/bcm/Adapter.h
> @@ -37,8 +37,10 @@ struct bcm_link_request {
> 
>  union u_ip_address {
>         struct {
> -               ULONG ulIpv4Addr[MAX_IP_RANGE_LENGTH]; /* Source Ip Address
> Range */
> -               ULONG ulIpv4Mask[MAX_IP_RANGE_LENGTH]; /* Source Ip Mask
> Address Range */
> +               /* Source Ip Address Range */
> +               ULONG ulIpv4Addr[MAX_IP_RANGE_LENGTH];
> +                /* Source Ip Mask Address Range */
> +               ULONG ulIpv4Mask[MAX_IP_RANGE_LENGTH];
>         };
>         struct {
>                 ULONG ulIpv6Addr[MAX_IP_RANGE_LENGTH * 4]; /* Source Ip
> Address Range */
> 
> -- 
> You received this message because you are subscribed to the Google Groups "opw-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to opw-kernel+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
diff mbox

Patch

diff --git a/drivers/staging/bcm/Adapter.h b/drivers/staging/bcm/Adapter.h
index f0d6f0c..1b2d9f3 100644
--- a/drivers/staging/bcm/Adapter.h
+++ b/drivers/staging/bcm/Adapter.h
@@ -37,8 +37,10 @@  struct bcm_link_request {

 union u_ip_address {
        struct {
-               ULONG ulIpv4Addr[MAX_IP_RANGE_LENGTH]; /* Source Ip Address
Range */
-               ULONG ulIpv4Mask[MAX_IP_RANGE_LENGTH]; /* Source Ip Mask
Address Range */
+               /* Source Ip Address Range */
+               ULONG ulIpv4Addr[MAX_IP_RANGE_LENGTH];
+                /* Source Ip Mask Address Range */
+               ULONG ulIpv4Mask[MAX_IP_RANGE_LENGTH];
        };