diff mbox

Resend: [OPW kernel] [PATCH] staging: bcm: Fix line over 80 characters.

Message ID CAFEh7=n4-D-_idpyYh6NU7ZaH4fwMUT7Nw59KtRVcx8uvBjzXA@mail.gmail.com
State New, archived
Headers show

Commit Message

Heena Sirwani March 16, 2014, 4:58 p.m. UTC
Fix checkpatch.pl issues with line over 80 characters in Adapter.h

Signed-off-by: Heena Sirwani <heenasirwani@gmail.com>
---
 drivers/staging/bcm/Adapter.h |    6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

        struct {
                ULONG ulIpv6Addr[MAX_IP_RANGE_LENGTH * 4]; /* Source Ip
Address Range */

Comments

Sarah Sharp March 17, 2014, 8:07 p.m. UTC | #1
On Sun, Mar 16, 2014 at 10:28:00PM +0530, Heena Sirwani wrote:
> Fix checkpatch.pl issues with line over 80 characters in Adapter.h
> 
> Signed-off-by: Heena Sirwani <heenasirwani@gmail.com>

Ok, this is not actually a "resend".  You've corrected your
Signed-off-by mail in this patch version, so the subject should be:

[PATCH v2] staging: bcm: Fix line over 80 characters.

> ---

You should put a change log here, describing what changed from your
previous patch (in this case, just adding a Signed-off-by line).

And actually, looking at the patches you've sent over the last couple of
days, all the patches should be combined into one patch to fix over 80
character lines.  The fact that you have the same subject line should be
a hint for that.

Can you put all the over 80-character changes into one patch, and send
the revised version with a [PATCH v2] subject and a changelog?  You'll
want to include things like the feedback Pablo gave you.  If you need to
see what a changelog looks like, please see the example here:

http://kernelnewbies.org/OPWfirstpatch#head-a0ba8e6d59dd8e0c0a1d20161047dee4bdaa3a9f

Thanks,
Sarah Sharp

>  drivers/staging/bcm/Adapter.h |    6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/bcm/Adapter.h b/drivers/staging/bcm/Adapter.h
> index f0d6f0c..1b2d9f3 100644
> --- a/drivers/staging/bcm/Adapter.h
> +++ b/drivers/staging/bcm/Adapter.h
> @@ -37,8 +37,10 @@ struct bcm_link_request {
> 
>  union u_ip_address {
>         struct {
> -               ULONG ulIpv4Addr[MAX_IP_RANGE_LENGTH]; /* Source Ip Address
> Range */
> -               ULONG ulIpv4Mask[MAX_IP_RANGE_LENGTH]; /* Source Ip Mask
> Address Range */
> +               /* Source Ip Address Range */
> +               ULONG ulIpv4Addr[MAX_IP_RANGE_LENGTH];
> +                /* Source Ip Mask Address Range */
> +               ULONG ulIpv4Mask[MAX_IP_RANGE_LENGTH];
>         };
>         struct {
>                 ULONG ulIpv6Addr[MAX_IP_RANGE_LENGTH * 4]; /* Source Ip
> Address Range */
> 
> -- 
> You received this message because you are subscribed to the Google Groups "opw-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to opw-kernel+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
diff mbox

Patch

diff --git a/drivers/staging/bcm/Adapter.h b/drivers/staging/bcm/Adapter.h
index f0d6f0c..1b2d9f3 100644
--- a/drivers/staging/bcm/Adapter.h
+++ b/drivers/staging/bcm/Adapter.h
@@ -37,8 +37,10 @@  struct bcm_link_request {

 union u_ip_address {
        struct {
-               ULONG ulIpv4Addr[MAX_IP_RANGE_LENGTH]; /* Source Ip Address
Range */
-               ULONG ulIpv4Mask[MAX_IP_RANGE_LENGTH]; /* Source Ip Mask
Address Range */
+               /* Source Ip Address Range */
+               ULONG ulIpv4Addr[MAX_IP_RANGE_LENGTH];
+                /* Source Ip Mask Address Range */
+               ULONG ulIpv4Mask[MAX_IP_RANGE_LENGTH];
        };